From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: More over-engineering Date: Fri, 27 Nov 2015 21:32:52 +0200 Message-ID: <83r3jbqluj.fsf@gnu.org> References: <83si3rqp96.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1448652814 29301 80.91.229.3 (27 Nov 2015 19:33:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Nov 2015 19:33:34 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 27 20:33:21 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a2Olk-0006z4-S4 for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 20:33:20 +0100 Original-Received: from localhost ([::1]:58264 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Oln-0004Na-Hj for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 14:33:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Olb-0004NT-FZ for emacs-devel@gnu.org; Fri, 27 Nov 2015 14:33:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2OlW-0000XZ-Ft for emacs-devel@gnu.org; Fri, 27 Nov 2015 14:33:11 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:56552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2OlW-0000XI-8H for emacs-devel@gnu.org; Fri, 27 Nov 2015 14:33:06 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NYH00I00NI9GF00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Fri, 27 Nov 2015 21:33:04 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NYH00I5PNN4FP10@a-mtaout20.012.net.il>; Fri, 27 Nov 2015 21:33:04 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195411 Archived-At: > From: Stefan Monnier > Cc: aurelien.aptel+emacs@gmail.com, emacs-devel@gnu.org > Date: Fri, 27 Nov 2015 13:53:22 -0500 > > >> should protect itself from signals and 'throw' in the called > >> Emacs functions, by placing the macros MODULE_HANDLE_SIGNALS > >> and/or MODULE_HANDLE_THROW right after the above 2 tests. > >> + FIXME: Why is it always needed? What happens if we don't? > >> + Why is only one of the two needed rather than always both? > > > I indeed think we should have only one macro that does the job of all > > three of them. It's on my todo to make that change, if no one beats > > me to it. > > How 'bout the other question: what happens if we don't use that macro? I assumed that question was rhetorical.