From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: aurelien.aptel+emacs@gmail.com, emacs-devel@gnu.org
Subject: Re: More over-engineering
Date: Fri, 27 Nov 2015 21:32:52 +0200 [thread overview]
Message-ID: <83r3jbqluj.fsf@gnu.org> (raw)
In-Reply-To: <jwvoaefs29h.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: aurelien.aptel+emacs@gmail.com, emacs-devel@gnu.org
> Date: Fri, 27 Nov 2015 13:53:22 -0500
>
> >> should protect itself from signals and 'throw' in the called
> >> Emacs functions, by placing the macros MODULE_HANDLE_SIGNALS
> >> and/or MODULE_HANDLE_THROW right after the above 2 tests.
> >> + FIXME: Why is it always needed? What happens if we don't?
> >> + Why is only one of the two needed rather than always both?
>
> > I indeed think we should have only one macro that does the job of all
> > three of them. It's on my todo to make that change, if no one beats
> > me to it.
>
> How 'bout the other question: what happens if we don't use that macro?
I assumed that question was rhetorical.
next prev parent reply other threads:[~2015-11-27 19:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 17:00 More over-engineering Stefan Monnier
2015-11-27 17:12 ` Aurélien Aptel
2015-11-27 17:37 ` David Kastrup
2015-11-27 18:02 ` Stefan Monnier
2015-11-27 18:19 ` Eli Zaretskii
2015-11-27 18:53 ` Stefan Monnier
2015-11-27 19:32 ` Eli Zaretskii [this message]
2015-11-27 21:55 ` Stefan Monnier
2015-11-28 7:51 ` Eli Zaretskii
2015-11-28 16:22 ` Stefan Monnier
2015-11-28 16:34 ` Eli Zaretskii
2015-11-28 23:13 ` Paul Eggert
2015-11-30 19:40 ` Stefan Monnier
2015-11-30 20:04 ` Eli Zaretskii
2015-11-30 20:39 ` Stefan Monnier
2015-11-30 20:49 ` Eli Zaretskii
2015-12-06 21:16 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r3jbqluj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aurelien.aptel+emacs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.