From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Override Windows default Win-* key combinations when using Emacs Date: Wed, 13 Jan 2016 17:53:21 +0200 Message-ID: <83r3hliiha.fsf@gnu.org> References: <568BBC58.50702@aprikoodi.fi> <83y4c43qkh.fsf@gnu.org> <5691667C.5000009@aprikoodi.fi> <838u3wkkvb.fsf@gnu.org> <5694E07E.8010005@aprikoodi.fi> <83fuy2kd2w.fsf@gnu.org> <56961607.2090504@aprikoodi.fi> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1452700847 21278 80.91.229.3 (13 Jan 2016 16:00:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jan 2016 16:00:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jussi Lahdenniemi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 13 17:00:47 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aJNqn-0001jV-RZ for ged-emacs-devel@m.gmane.org; Wed, 13 Jan 2016 17:00:45 +0100 Original-Received: from localhost ([::1]:37868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJNqn-0004mJ-9m for ged-emacs-devel@m.gmane.org; Wed, 13 Jan 2016 11:00:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJNjV-0006IG-5I for emacs-devel@gnu.org; Wed, 13 Jan 2016 10:53:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJNjR-0004M5-Tf for emacs-devel@gnu.org; Wed, 13 Jan 2016 10:53:13 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJNjR-0004M1-Qm; Wed, 13 Jan 2016 10:53:09 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1587 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aJNjR-0000oU-75; Wed, 13 Jan 2016 10:53:09 -0500 In-reply-to: <56961607.2090504@aprikoodi.fi> (message from Jussi Lahdenniemi on Wed, 13 Jan 2016 11:16:55 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198111 Archived-At: > Cc: emacs-devel@gnu.org > From: Jussi Lahdenniemi > Date: Wed, 13 Jan 2016 11:16:55 +0200 > > On 12.1.2016 17.54, Eli Zaretskii wrote: > > Which APIs that you used in the patch are not available on Windows 9X? > > I thought I went over all of them, and they all are, but maybe I > > missed some. > > By the way, now that I tried running Emacs on Win98 and Win2k I noticed > that the commit 7afa4f300 by you in August seems to break compatibility > with these old operating systems by linking to the function > _resetstkoflw in msvcrt.dll. The function was apparently introduced in > version 7.0 of msvcrt.dll, while Win2k still ships with version 6.1. My references were ambiguous about that when I wrote that code. Can you replace the direct call to _resetstkoflw with a call through a pointer which is assigned the right address at run time, if the function available, and avoid calling it if not? Like what we do with the other such functions in w32.c and elsewhere. I can write the code for this, if you want, but I cannot test it. Thanks.