all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Use of strftime in movemail.ec
@ 2016-03-05 11:01 Eli Zaretskii
  2016-03-05 19:39 ` Paul Eggert
  0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2016-03-05 11:01 UTC (permalink / raw)
  To: Paul Eggert; +Cc: emacs-devel

movemail.c uses strftime as follows:

  char fromline[100];
  if (! strftime (fromline, sizeof fromline,
		  "From movemail %a %b %e %T %Y\n", ltime))

The %e and %T formats are not supported by the MS-Windows runtime
version of strftime, and the result is that movemail produces mbox
files where Rmail doesn't see any valid email messages.

I believe these format specifiers were used under the assumption that
Gnulib's strftime will be used on systems that don't support the full
functionality.  However, Gnulib's strftime.c defines a function
my_strftime, which is renamed by config.h as nstrftime, and I don't
see anywhere any machinery to force movemail call nstrftime.  Am I
missing something?

For now, I pushed a change to emacs-25 (commit 7923112) to use only
portable specifiers there.  But if a simple and safe change can be
made that would cause nstrftime be called by movemail (without any
adverse effects on Emacs itself), let's do that instead.



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-03-06 16:28 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-05 11:01 Use of strftime in movemail.ec Eli Zaretskii
2016-03-05 19:39 ` Paul Eggert
2016-03-05 19:58   ` Eli Zaretskii
2016-03-05 20:37     ` Eli Zaretskii
2016-03-05 20:56       ` Paul Eggert
2016-03-06 16:28         ` Eli Zaretskii
2016-03-05 20:53     ` Paul Eggert

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.