bug#23020: 25.1.50; smtpmail reports that it's sent the message before it's sent

bug#23020: 25.1.50; smtpmail reports that it's sent the message before it's sent

[Lars Magne Ingebrigtsen]

When the receiving MTA rejects the message after DATA has ended (which
is typical for spam filtering MTAs), these are the messages:

Sending via mail...
Sending email 
Sending email done
smtpmail-send-it: Sending failed: 550 This message scored too many spam points in response to .

So it shouldn't say "done" until it's really done.



In GNU Emacs 25.1.50.26 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
 of 2016-03-12 built on stories
Repository revision: 63efcc268635dea78c6bd80749eae4ee2c72d717
Windowing system distributor 'The X.Org Foundation', version 11.0.11204000
System Description:	Debian GNU/Linux 7.9 (wheezy)

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GSETTINGS NOTIFY GNUTLS
LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US
  locale-coding-system: iso-latin-1-unix

Major mode: Group

Minor modes in effect:
  gnus-agent-group-mode: t
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  gnus-topic-mode: t
  gnus-undo-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t

Recent messages:
No more unseen articles
No more unread articles
Resending message to learn-spam@hermes.netfonds.no...
Mark set [3 times]
Sending via mail...
Sending email 
Sending email done
smtpmail-send-it: Sending failed: 550 This message scored too many spam points in response to .
Mark set [2 times]
Making completion list...

Load-path shadows:
/home/larsi/src/clock.el/clock hides /home/larsi/lisp/clock
/home/larsi/src/cddb.el/expect hides /home/larsi/lisp/expect
/home/larsi/src/pvr.el/pvr hides /home/larsi/lisp/pvr
~/pgnus/contrib/vcard hides /home/larsi/lisp/vcard
/home/larsi/src/cddb.el/captitle hides /home/larsi/lisp/captitle
~/lisp/zenirc-2.112/src/zenirc-example hides /home/larsi/lisp/zenirc-example
/home/larsi/lisp/dom hides /home/larsi/src/emacs/trunk/lisp/dom
~/pgnus/contrib/compface hides /home/larsi/src/emacs/trunk/lisp/image/compface

Features:
(shadow emacsbug ffap log-edit pcvs-util vc-bzr vc-src vc-sccs vc-svn
vc-rcs vc-dir ewoc bug-reference tramp-cache tramp tramp-compat
tramp-loaddefs trampver ucs-normalize advice sh-script smie executable
nndir nnspool nnagent view sgml-mode cal-move cal-menu calendar
cal-loaddefs compile pp dired-aux jukebox humanely-sort lyric-wiki
discogs json dae musicbrainz scan scrobble tellstick wave cddb captitle
expect mailalias smtpmail sendmail ecomplete shell pcomplete comint
whitespace map flow-fill edebug pulse find-func thingatpt xref project
ring misearch multi-isearch rect vc-git diff-mode canlock server eww vc
vc-dispatcher gnus-html url-queue help-fns url-cache gnus-picon sort
gnus-cite smiley ansi-color shr-color color mm-archive gnus-async
gnus-dup qp gnus-ml gmane spam-gmane dns mm-url disp-table gnus-fun
gnus-mdrtn pop3 nndoc nnmbox nndraft utf-7 gnus-topic nnmh nnml nnfolder
copyright vc-cvs network-stream nsm starttls nnir spam-report spam
spam-stat gnus-uu yenc gnus-agent gnus-srvr gnus-score score-mode
nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig
nntp gnus-cache gnus-sum gnus-group gnus-undo gnus-start gnus-cloud
nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int
gnus-range message format-spec rfc822 mml mml-sec epa epg mailabbrev
gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail
rmail-loaddefs mail-utils movie mkv shr svg imdb dom pvr debug
debbugs-gnu easy-mmode derived debbugs soap-client mm-decode mm-bodies
mm-encode url-http tls gnutls url-auth mail-parse rfc2231 rfc2047
rfc2045 ietf-drums url-gw puny url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util mailcap warnings
rng-xsd rng-dt rng-util xsd-regexp xml ido seq flyspell ispell benchmark
w3m browse-url doc-view subr-x dired dired-loaddefs image-mode timezone
w3m-hist w3m-fb w3m-ems wid-edit w3m-ccl ccl w3m-favicon w3m-image
w3m-proc w3m-util add-log mail-extr mm-util mail-prsvr jka-compr cl
finder-inf package epg-config url-handlers url-parse auth-source cl-seq
eieio byte-opt bytecomp byte-compile cl-extra help-mode easymenu cconv
eieio-core cl-macs gv eieio-loaddefs cl-loaddefs pcase cl-lib
password-cache url-vars time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 4580524 371820)
 (symbols 48 179414 310)
 (miscs 40 1697 5372)
 (strings 32 393177 44605)
 (string-bytes 1 41891186)
 (vectors 16 75981)
 (vector-slots 8 2186725 232032)
 (floats 8 9667 6346)
 (intervals 56 996348 8081)
 (buffers 976 386)
 (heap 1024 481505 230008))

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#23020: 25.1.50; smtpmail reports that it's sent the message before it's sent

[Eli Zaretskii]

> From: Lars Magne Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 15 Mar 2016 11:24:32 +0100
> 
> 
> When the receiving MTA rejects the message after DATA has ended (which
> is typical for spam filtering MTAs), these are the messages:
> 
> Sending via mail...
> Sending email 
> Sending email done
> smtpmail-send-it: Sending failed: 550 This message scored too many spam points in response to .
> 
> So it shouldn't say "done" until it's really done.

Isn't it message.el that says "done" in this case?

bug#23020: 25.1.50; smtpmail reports that it's sent the message before it's sent

[Lars Magne Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> Sending email 
>> Sending email done
>> smtpmail-send-it: Sending failed: 550 This message scored too many
>> spam points in response to .
>> 
>> So it shouldn't say "done" until it's really done.
>
> Isn't it message.el that says "done" in this case?

I think it must be this code...  I can't find the string "Sending email"
in message.el.

(defun smtpmail-send-data (process buffer)
  (let ((data-continue t) sending-data
        (pr (with-current-buffer buffer
              (make-progress-reporter "Sending email "
                                      (point-min) (point-max)))))
    (with-current-buffer buffer
      (goto-char (point-min)))
    (while data-continue
      (with-current-buffer buffer
        (progress-reporter-update pr (point))
        (setq sending-data (buffer-substring (point-at-bol) (point-at-eol)))
	(end-of-line 2)
        (setq data-continue (not (eobp))))
      (smtpmail-send-data-1 process sending-data))
    (progress-reporter-done pr)))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#23020: 25.1.50; smtpmail reports that it's sent the message before it's sent

[Lars Magne Ingebrigtsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> I think it must be this code...  I can't find the string "Sending email"
> in message.el.

Yup.  Now fixed on the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#23020: 25.1.50; smtpmail reports that it's sent the message before it's sent

[Eli Zaretskii]

> From: Lars Magne Ingebrigtsen <larsi@gnus.org>
> Cc: 23020@debbugs.gnu.org
> Date: Tue, 26 Apr 2016 00:54:20 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Sending email 
> >> Sending email done
> >> smtpmail-send-it: Sending failed: 550 This message scored too many
> >> spam points in response to .
> >> 
> >> So it shouldn't say "done" until it's really done.
> >
> > Isn't it message.el that says "done" in this case?
> 
> I think it must be this code...  I can't find the string "Sending email"
> in message.el.
> 
> (defun smtpmail-send-data (process buffer)
>   (let ((data-continue t) sending-data
>         (pr (with-current-buffer buffer
>               (make-progress-reporter "Sending email "
>                                       (point-min) (point-max)))))
>     (with-current-buffer buffer
>       (goto-char (point-min)))
>     (while data-continue
>       (with-current-buffer buffer
>         (progress-reporter-update pr (point))
>         (setq sending-data (buffer-substring (point-at-bol) (point-at-eol)))
> 	(end-of-line 2)
>         (setq data-continue (not (eobp))))
>       (smtpmail-send-data-1 process sending-data))
>     (progress-reporter-done pr)))

But if this is the code, then it says "done" when it really is done,
no?

bug#23020: 25.1.50; smtpmail reports that it's sent the message before it's sent

[Lars Magne Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> But if this is the code, then it says "done" when it really is done,
> no?

No, this is just sending the data.  The SMTP server is free to reject
the message after sending the final ".", which was done after sending
the data.

So I made it send the "." before saying "done".

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no