From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tests, Emacs-25 and Conditional Features Date: Fri, 18 Mar 2016 20:38:46 +0200 Message-ID: <83r3f78wcp.fsf@gnu.org> References: <87k2l2zgre.fsf@russet.org.uk> <87h9g6xzrb.fsf@gmx.de> <87shzpxvfv.fsf@russet.org.uk> <83bn6d9iml.fsf@gnu.org> <87zitwf4pz.fsf@russet.org.uk> <87pousdp9g.fsf@gmx.de> <87vb4jemat.fsf@russet.org.uk> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1458326375 15807 80.91.229.3 (18 Mar 2016 18:39:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Mar 2016 18:39:35 +0000 (UTC) Cc: michael.albinus@gmx.de, emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 18 19:39:34 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1agzJ7-0002ui-Vh for ged-emacs-devel@m.gmane.org; Fri, 18 Mar 2016 19:39:34 +0100 Original-Received: from localhost ([::1]:45733 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agzJ7-0006G2-EI for ged-emacs-devel@m.gmane.org; Fri, 18 Mar 2016 14:39:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agzIn-0006Dk-SE for emacs-devel@gnu.org; Fri, 18 Mar 2016 14:39:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agzIl-0007m4-4L for emacs-devel@gnu.org; Fri, 18 Mar 2016 14:39:13 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agzIl-0007lu-1b; Fri, 18 Mar 2016 14:39:11 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1551 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1agzIj-0008CH-Vj; Fri, 18 Mar 2016 14:39:10 -0400 In-reply-to: <87vb4jemat.fsf@russet.org.uk> (phillip.lord@russet.org.uk) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201842 Archived-At: > From: phillip.lord@russet.org.uk (Phillip Lord) > Date: Fri, 18 Mar 2016 17:19:22 +0000 > Cc: Eli Zaretskii , emacs-devel@gnu.org > > Michael Albinus writes: > > > phillip.lord@russet.org.uk (Phillip Lord) writes: > > > > Hi Philip, > > > >> Something like > >> > >> (skip-unless (or (gnutls-available-p) conditional-feature-force)) > >> > >> So, we pick have a standard test selector which means "all the > >> conditional features should be expected to be on". Probably, you would > >> want "all the conditional features that are supposed to be on by > >> default, should be expected to be on" > > > > That does not exist for everything. For example, in the file > > notification case there are 5 different possible "conditional features", > > all of them valid: > > > > - inotify enabled > > - kqueue enabled > > - gfilenotify enabled > > - w32notify enable > > - file notification disabled. > > > > How does a test library shall know what is intended by the user? > > Good point, although, if I understand the notification correctly, you > have an abstraction layer over these? The abstraction layer is not relevant if you want to test the low-level functionality.