From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23179: 25.0.92; Restore `M-,' to continue etags search Date: Tue, 05 Apr 2016 18:12:25 +0300 Message-ID: <83r3ekm6na.fsf@gnu.org> References: <48066d7c-e4d3-acf5-fdcf-1aa9a108cb90@yandex.ru> <83bn5ttwul.fsf@gnu.org> <83shz4sdi0.fsf@gnu.org> <5a9b5719-ea84-89bc-c0c5-37692fafd23d@yandex.ru> <83inzypm94.fsf@gnu.org> <83d1q6plhb.fsf@gnu.org> <83a8lapkpt.fsf@gnu.org> <831t6mozrd.fsf@gnu.org> <83mvp9nzl9.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459869269 25359 80.91.229.3 (5 Apr 2016 15:14:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Apr 2016 15:14:29 +0000 (UTC) Cc: 23179@debbugs.gnu.org, andlind@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 05 17:14:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1anSgJ-0007da-NP for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Apr 2016 17:14:15 +0200 Original-Received: from localhost ([::1]:37643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anSgJ-00075a-5z for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Apr 2016 11:14:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anSgA-0006zK-E4 for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2016 11:14:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anSg6-00021T-9d for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2016 11:14:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anSg6-00021P-5W for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2016 11:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1anSg6-0004hF-2X for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2016 11:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Apr 2016 15:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23179-submit@debbugs.gnu.org id=B23179.145986919017948 (code B ref 23179); Tue, 05 Apr 2016 15:14:02 +0000 Original-Received: (at 23179) by debbugs.gnu.org; 5 Apr 2016 15:13:10 +0000 Original-Received: from localhost ([127.0.0.1]:52473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anSfF-0004fP-9Q for submit@debbugs.gnu.org; Tue, 05 Apr 2016 11:13:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anSfD-0004fB-Uw for 23179@debbugs.gnu.org; Tue, 05 Apr 2016 11:13:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anSf2-0001RH-44 for 23179@debbugs.gnu.org; Tue, 05 Apr 2016 11:13:01 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anSev-0001Nq-TN; Tue, 05 Apr 2016 11:12:49 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4271 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1anSev-0003zJ-5e; Tue, 05 Apr 2016 11:12:49 -0400 In-reply-to: (message from Dmitry Gutov on Mon, 4 Apr 2016 19:53:44 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:116062 Archived-At: > Cc: 23179@debbugs.gnu.org, Anders Lindgren > From: Dmitry Gutov > Date: Mon, 4 Apr 2016 19:53:44 +0300 > > On 04/04/2016 06:49 PM, Eli Zaretskii wrote: > > >> I only want the xref UI to be displayed when doing commands like `find-all-occurences' etc. When doing a > >> plain search, there is no need for it. > > > > Dmitry, is the patch below okay with you? Any comments? (I will add > > documentation if this is acceptable.) > > First, it would take effect in both xref-find-definitions and > xref-find-references, whereas Anders said that he wants that UI only for > the former, IIUC. Anders, is that so? If so, can you tell with which commands you'd like to see the UI and with which not to see it, and why? > Second, I'd rather you instead create a new separate function to set > xref-show-xrefs-function to. > > For now, you can copy the definition of xref--show-xref-buffer and > modify it not to show the buffer. That will make it easier to make > independent changes in that new UI. As well as make it easier for me to > disclaim the responsibility for it (sorry). I hope you are joking. Since when does anyone need to disclaim responsibility for some code? And even if someone does, "git blame" will blame the guilty parties right away. Copying a function only to change a line or two sounds extreme to me. > Go ahead if Anders likes it, but personally I don't see a lot of point, > at least as long as the user still has to wait until all results are > fetched. The point is to be able to tell people who, like Anders, don't want to see the UI to use the option to get what they want, instead of arguing with them trying to convince them that the UI is for their best.