From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status' Date: Tue, 04 Oct 2016 17:43:18 +0300 Message-ID: <83r37wmayh.fsf@gnu.org> References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> <83k2dpq517.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1475592291 1974 195.159.176.226 (4 Oct 2016 14:44:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Oct 2016 14:44:51 +0000 (UTC) Cc: monnier@iro.umontreal.ca, 24555-done@debbugs.gnu.org To: Philippe Vaucher Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 04 16:44:46 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brQxC-0005QU-3S for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Oct 2016 16:44:22 +0200 Original-Received: from localhost ([::1]:43143 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brQxD-0003xa-OU for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Oct 2016 10:44:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brQwx-0003qP-6h for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 10:44:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brQws-0006PA-OM for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 10:44:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brQws-0006P5-LB for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 10:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1brQws-0000Fv-H7 for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 10:44:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2016 14:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24555 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 24555@debbugs.gnu.org, eliz@gnu.org, philippe.vaucher@gmail.com Original-Received: via spool by 24555-done@debbugs.gnu.org id=D24555.1475592222939 (code D ref 24555); Tue, 04 Oct 2016 14:44:02 +0000 Original-Received: (at 24555-done) by debbugs.gnu.org; 4 Oct 2016 14:43:42 +0000 Original-Received: from localhost ([127.0.0.1]:44540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brQwV-0000F0-2q for submit@debbugs.gnu.org; Tue, 04 Oct 2016 10:43:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brQwP-0000Ej-8O for 24555-done@debbugs.gnu.org; Tue, 04 Oct 2016 10:43:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brQwE-0005mi-A3 for 24555-done@debbugs.gnu.org; Tue, 04 Oct 2016 10:43:28 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brQwE-0005lu-6d; Tue, 04 Oct 2016 10:43:22 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3437 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1brQwC-0007QL-BB; Tue, 04 Oct 2016 10:43:20 -0400 In-reply-to: (message from Philippe Vaucher on Mon, 3 Oct 2016 09:42:14 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124037 Archived-At: > From: Philippe Vaucher > Date: Mon, 3 Oct 2016 09:42:14 +0200 > Cc: Stefan Monnier , 24555@debbugs.gnu.org > > And again new patches without a typo :-) Thanks, I pushed this to the emacs-25 branch, and I'm marking this bug done. Please note that your patch had a fatal flaw: specbind needs a (quoted) symbol, not its value. Using Vcommand_debug_status there produced a broken binary that would display an error message and become unresponsive. See what I actually committed for the details. Also, the obsolescence warning needed some minor tweaks (it turns out that my advice to prepend a semi-colon was a bad idea, as a semi-colon and a newline are produced by Emacs automatically). Please always test the build after you patch it, to make sure the behavior is correct and no bugs creep in. Finally, in the future please provide commit log messages for the changes formatted in the ChanegLog style, as described in CONTRIBUTE. I wrote them for this commit, please see the commit for the details of the formatting we use. Thanks a lot for working on this.