From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23692: 25.1.50; Package.el gets confused if file has no autoloads (could be a bug in update-directory-autoloads) Date: Mon, 10 Oct 2016 12:56:02 +0300 Message-ID: <83r37oede5.fsf@gnu.org> References: <5751FEC2.5080807@live.com> <22y46lx4yq.fsf@fencepost.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1476093926 26931 195.159.176.226 (10 Oct 2016 10:05:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 10 Oct 2016 10:05:26 +0000 (UTC) Cc: 23692@debbugs.gnu.org, clement.pitclaudel@live.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 10 12:05:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btXSB-0004Kq-Ev for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Oct 2016 12:05:03 +0200 Original-Received: from localhost ([::1]:48579 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btXSA-00026Z-2k for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Oct 2016 06:05:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btXKU-0004q6-VH for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2016 05:57:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btXKQ-0006Ei-NW for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2016 05:57:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btXKQ-0006Ea-JX for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2016 05:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1btXKQ-00083r-Fp for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2016 05:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Oct 2016 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23692 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23692-submit@debbugs.gnu.org id=B23692.147609336230884 (code B ref 23692); Mon, 10 Oct 2016 09:57:02 +0000 Original-Received: (at 23692) by debbugs.gnu.org; 10 Oct 2016 09:56:02 +0000 Original-Received: from localhost ([127.0.0.1]:50501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btXJR-000821-NJ for submit@debbugs.gnu.org; Mon, 10 Oct 2016 05:56:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btXJQ-00081m-39 for 23692@debbugs.gnu.org; Mon, 10 Oct 2016 05:56:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btXJH-0005Oj-SY for 23692@debbugs.gnu.org; Mon, 10 Oct 2016 05:55:54 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btXJH-0005Nw-PH; Mon, 10 Oct 2016 05:55:51 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2888 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1btXJF-0001Ka-Ej; Mon, 10 Oct 2016 05:55:49 -0400 In-reply-to: (message from Stefan Monnier on Mon, 13 Jun 2016 20:40:24 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124290 Archived-At: > From: Stefan Monnier > Date: Mon, 13 Jun 2016 20:40:24 -0400 > Cc: Clément Pit--Claudel , > 23692@debbugs.gnu.org > > > i) I guess now autoload will sometimes not create any output file. > > I think this shouldn't happen. Both in the sense that it would be > a bug, and that my understanding of the code makes me think it > won't happen. We create the file before we even try to update it. > > > ii) I wonder what this means for reproducibility of the loaddefs file. > > Good question. > > > iii) Would applying a move-if-change style logic be better? > > Could be, indeed. My only motivation for the original patch was to > avoid repeatedly re-dumping Emacs even when no significant change had > happened. I wrote the patch years ago, and at that point the > time-stamps were always different, so the buffer's content was > definitely changed, tho in ways which had no impact on the dump, so > "move-if-changed" was not an option. > Now that we avoid time-stamps maybe we can actually compare the buffer's > content with the file and skip saving if it's identical. Stefan, you didn't commit your patch, please do (it should go to the master branch). TIA