From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 23692@debbugs.gnu.org, clement.pitclaudel@live.com
Subject: bug#23692: 25.1.50; Package.el gets confused if file has no autoloads (could be a bug in update-directory-autoloads)
Date: Mon, 10 Oct 2016 12:56:02 +0300 [thread overview]
Message-ID: <83r37oede5.fsf@gnu.org> (raw)
In-Reply-To: <jwv7fdsvcfb.fsf-monnier+emacsbugs@gnu.org> (message from Stefan Monnier on Mon, 13 Jun 2016 20:40:24 -0400)
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Date: Mon, 13 Jun 2016 20:40:24 -0400
> Cc: Clément Pit--Claudel <clement.pitclaudel@live.com>,
> 23692@debbugs.gnu.org
>
> > i) I guess now autoload will sometimes not create any output file.
>
> I think this shouldn't happen. Both in the sense that it would be
> a bug, and that my understanding of the code makes me think it
> won't happen. We create the file before we even try to update it.
>
> > ii) I wonder what this means for reproducibility of the loaddefs file.
>
> Good question.
>
> > iii) Would applying a move-if-change style logic be better?
>
> Could be, indeed. My only motivation for the original patch was to
> avoid repeatedly re-dumping Emacs even when no significant change had
> happened. I wrote the patch years ago, and at that point the
> time-stamps were always different, so the buffer's content was
> definitely changed, tho in ways which had no impact on the dump, so
> "move-if-changed" was not an option.
> Now that we avoid time-stamps maybe we can actually compare the buffer's
> content with the file and skip saving if it's identical.
Stefan, you didn't commit your patch, please do (it should go to the
master branch).
TIA
next prev parent reply other threads:[~2016-10-10 9:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 22:03 bug#23692: 25.1.50; Package.el gets confused if file has no autoloads (could be a bug in update-directory-autoloads) Clément Pit--Claudel
2016-06-03 22:50 ` Glenn Morris
2016-06-04 4:34 ` Clément Pit--Claudel
2016-06-06 17:24 ` Glenn Morris
2016-06-09 1:47 ` Stefan Monnier
2016-06-13 18:33 ` Glenn Morris
2016-06-14 0:40 ` Stefan Monnier
2016-10-10 9:56 ` Eli Zaretskii [this message]
2016-10-11 19:56 ` Stefan Monnier
2016-10-11 20:54 ` Eli Zaretskii
2016-06-13 22:17 ` Clément Pit--Claudel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r37oede5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23692@debbugs.gnu.org \
--cc=clement.pitclaudel@live.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.