From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24923: 25.1; Lisp watchpoints Date: Sat, 12 Nov 2016 09:19:21 +0200 Message-ID: <83r36hcghy.fsf@gnu.org> References: <87vavun235.fsf@users.sourceforge.net> <83eg2ie3lp.fsf@gnu.org> <87pom1mi3q.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1478935236 22898 195.159.176.226 (12 Nov 2016 07:20:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Nov 2016 07:20:36 +0000 (UTC) Cc: 24923@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 12 08:20:32 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5Sbh-0002E7-N1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Nov 2016 08:20:09 +0100 Original-Received: from localhost ([::1]:57080 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5Sbk-00051B-PN for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Nov 2016 02:20:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5Sbd-0004zG-36 for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2016 02:20:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5SbZ-0005Qw-UT for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2016 02:20:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39008) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c5SbZ-0005Qk-RX for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2016 02:20:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c5SbZ-00005r-IM for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2016 02:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Nov 2016 07:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24923-submit@debbugs.gnu.org id=B24923.1478935165303 (code B ref 24923); Sat, 12 Nov 2016 07:20:01 +0000 Original-Received: (at 24923) by debbugs.gnu.org; 12 Nov 2016 07:19:25 +0000 Original-Received: from localhost ([127.0.0.1]:54407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5Saz-0008WU-Dx for submit@debbugs.gnu.org; Sat, 12 Nov 2016 02:19:25 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5Sax-0008WD-IV for 24923@debbugs.gnu.org; Sat, 12 Nov 2016 02:19:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5Sap-0004wb-5C for 24923@debbugs.gnu.org; Sat, 12 Nov 2016 02:19:18 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5Sap-0004wW-1E; Sat, 12 Nov 2016 02:19:15 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3021 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c5Sao-0004j2-BB; Sat, 12 Nov 2016 02:19:14 -0500 In-reply-to: <87pom1mi3q.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125639 Archived-At: > From: npostavs@users.sourceforge.net > Cc: 24923@debbugs.gnu.org > Date: Fri, 11 Nov 2016 23:34:33 -0500 > > >> + (_ (format "watchpoint triggered %S" (cdr args)))) > > > > Can you give a couple of examples of this, with %S shown explicitly? > > I'm not sure whether the result will be self-explanatory. > > You mean examples of this this clause being used? It was meant more as > a catchall in case some watch types were missed by the previous clauses. > It shouldn't really ever happen unless the debugger and watchpoint code > get out of sync. Do you think it would be better to just signal an > error? (although would signalling an error while the debugger is > invoked cause trouble?) Either signal an error, or include something like "(please submit a bug report)" in the text. > >> +;;;###autoload > >> +(defun debug-watch (variable) > >> + (interactive > >> + (let* ((var-at-point (variable-at-point)) > >> + (var (and (symbolp var-at-point) var-at-point)) > >> + (val (completing-read > >> + (concat "Debug when setting variable" > >> + (if var (format " (default %s): " var) ": ")) > > > > I think all the other commands/variables similar to this one are named > > debug-on-SOMETHING, so perhaps this one should also have such a name. > > Like debug-on-setting-variable, perhaps? > > Hah, I initially called this debug-on-set > (https://lists.nongnu.org/archive/html/emacs-devel/2015-11/txtyjJDztIULG.txt), > and then you suggested debug-watch instead > (https://lists.nongnu.org/archive/html/emacs-devel/2015-11/msg02017.html). > > An alias probably makes sense, how about debug-on-variable-change? > (since it catches some changes other than `set'.) Fine with me, thanks.