From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it. Date: Mon, 24 Jul 2017 20:01:14 +0300 Message-ID: <83r2x57orp.fsf@gnu.org> References: <20170723072843.23485.53761@vcs0.savannah.gnu.org> <20170723072844.877FD22EF0@vcs0.savannah.gnu.org> <87inijxnda.fsf@detlef> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1500915715 9392 195.159.176.226 (24 Jul 2017 17:01:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Jul 2017 17:01:55 +0000 (UTC) Cc: michael.albinus@gmx.de, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 24 19:01:52 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZgjq-0001zD-SJ for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 19:01:47 +0200 Original-Received: from localhost ([::1]:55953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZgjw-0005FN-EL for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 13:01:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZgjP-0005F6-Rt for emacs-devel@gnu.org; Mon, 24 Jul 2017 13:01:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZgjM-0007Do-Q7 for emacs-devel@gnu.org; Mon, 24 Jul 2017 13:01:19 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZgjM-0007Di-N2; Mon, 24 Jul 2017 13:01:16 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3536 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dZgjL-0001NT-TD; Mon, 24 Jul 2017 13:01:16 -0400 In-reply-to: (message from Glenn Morris on Mon, 24 Jul 2017 12:57:41 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216982 Archived-At: > From: Glenn Morris > Date: Mon, 24 Jul 2017 12:57:41 -0400 > Cc: Stefan Monnier , emacs-devel@gnu.org > > --- i/lisp/display-line-numbers.el > +++ w/lisp/display-line-numbers.el > @@ -38,7 +38,6 @@ display-line-numbers > "Display line numbers in the buffer." > :group 'display) > > -;;;###autoload > (defcustom display-line-numbers-type t > "The default type of line numbers to use in `display-line-numbers-mode'. > See `display-line-numbers' for value options." > diff --git i/lisp/menu-bar.el w/lisp/menu-bar.el > index 05a336b..e02217f 100644 > --- i/lisp/menu-bar.el > +++ w/lisp/menu-bar.el > @@ -1101,6 +1101,9 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom > :button (:radio . (eq tool-bar-mode nil)))) > menu))) > > +;; Following function calls will autoload the library. > +(defvar display-line-numbers-type) > + > (defun menu-bar-display-line-numbers-mode (type) > (setq display-line-numbers-type type) > (if global-display-line-numbers-mode How is this better than the autoload? At least the autoload doesn't need a comment to explain why it is there.