From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Question about test failure on Hydra Date: Sun, 30 Jul 2017 18:59:34 +0300 Message-ID: <83r2wx29w9.fsf@gnu.org> References: <87efsxexf5.fsf@rosalinde> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1501430411 13578 195.159.176.226 (30 Jul 2017 16:00:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Jul 2017 16:00:11 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Berman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 30 18:00:04 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbqdJ-0002Sq-9X for ged-emacs-devel@m.gmane.org; Sun, 30 Jul 2017 17:59:57 +0200 Original-Received: from localhost ([::1]:55704 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbqdK-0000kf-9M for ged-emacs-devel@m.gmane.org; Sun, 30 Jul 2017 11:59:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbqd6-0000kM-9C for emacs-devel@gnu.org; Sun, 30 Jul 2017 11:59:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbqd3-0002Bc-1V for emacs-devel@gnu.org; Sun, 30 Jul 2017 11:59:44 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbqd2-0002BR-Ut; Sun, 30 Jul 2017 11:59:40 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2364 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dbqd2-0001vJ-Fy; Sun, 30 Jul 2017 11:59:40 -0400 In-reply-to: <87efsxexf5.fsf@rosalinde> (message from Stephen Berman on Sun, 30 Jul 2017 17:50:38 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217164 Archived-At: > From: Stephen Berman > Date: Sun, 30 Jul 2017 17:50:38 +0200 > > (ert-deftest dired-test-bug27243-01 () > "Test for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27243#5 ." > (let ((test-dir (make-temp-file "test-dir-" t)) > (dired-auto-revert-buffer t) buffers) > (with-current-buffer (find-file-noselect test-dir) > (make-directory "test-subdir")) > (push (dired test-dir) buffers) > (unwind-protect > (let ((buf (current-buffer)) > (pt1 (point)) > (test-file (concat (file-name-as-directory "test-subdir") > "test-file"))) > (write-region "Test" nil test-file nil 'silent nil 'excl) > ;; Sanity check: point should now be on the subdirectory. > (should (equal (dired-file-name-at-point) > (concat (file-name-as-directory test-dir) > (file-name-as-directory "test-subdir")))) > > When it fails, Hydra show dired-file-name-at-point returning e.g. this > (it's a temporary directory so the name is different on each test run): > > "/build/test-dir-26691mMc/../" > > while the concat sexp it's being compared with returns (e.g.) this: > > "/build/test-dir-26691mMc/test-subdir/" > > IIUC dired-file-name-at-point can only return the above result if point > is on the ".." entry in Dired. But the sexp (dired test-dir) should > (and in all my test runs does) put point on the first "nontrivial" file > (i.e. it skips "." and ".."). I don't see how the above code can lead > to the failure Hydra reports. And again, it doesn't always fail in > Hydra. Does anyone have any idea what's going on here and what to do > about it? Doesn't dired-auto-revert-buffer by default use some kind of file notifications? If so, this could be some race between the notification coming in and the rest. You could introduce a wait to try to solve that, or maybe try turning off file notifications.