all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Nicolas Petton <nicolas@petton.fr>
Cc: tino.calancha@gmail.com, 27584@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#27584: 26.0.50; alist-get: Add optional arg TESTFN
Date: Tue, 01 Aug 2017 21:53:29 +0300	[thread overview]
Message-ID: <83r2wvyv9y.fsf@gnu.org> (raw)
In-Reply-To: <87efsvcjx4.fsf@petton.fr> (message from Nicolas Petton on Tue, 01 Aug 2017 18:49:43 +0200)

> From: Nicolas Petton <nicolas@petton.fr>
> Cc: tino.calancha@gmail.com, 27584@debbugs.gnu.org, monnier@iro.umontreal.ca
> Date: Tue, 01 Aug 2017 18:49:43 +0200
> 

A few comments:

> * doc/lispref/lists.texi: Document the change.

This should state the node in parentheses (as if it were a function).

> +@defun rassoc value alist &optional testfn
>  This function returns the first association with value @var{value} in
> -@var{alist}.  It returns @code{nil} if no association in @var{alist} has
> -a @sc{cdr} @code{equal} to @var{value}.
> +@var{alist}, comparing @var{value} against the alist elements using
> +@var{testfn} if non-nil, or @code{equal} if nil (@pxref{Equality

The "if nil" part is confusing, because you actually mean "if
@var{testfn} is nil".

Also, "nil" should be in @code.

> +Predicates}).  It returns @code{nil} if no association in @var{alist}
> +has a @sc{cdr} equal to @var{value}.

That reference to cdr is a surprise.  the original description talked
about cdr right from the start, but the new one doesn't.

Thanks.





  reply	other threads:[~2017-08-01 18:53 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05  3:22 bug#27584: 26.0.50; alist-get: Add optional arg TESTFN Tino Calancha
2017-07-05  8:53 ` Tino Calancha
2017-07-05  9:19 ` Nicolas Petton
2017-07-05 13:18   ` Tino Calancha
2017-07-06  6:05     ` Tino Calancha
2017-07-06  6:13       ` Stefan Monnier
2017-07-06  6:20         ` Tino Calancha
2017-07-06  9:36           ` Nicolas Petton
2017-07-06 10:55             ` Tino Calancha
2017-07-06 11:06               ` Nicolas Petton
2017-07-06 15:07           ` Stefan Monnier
2017-07-07  6:48             ` Tino Calancha
2017-07-07  7:46               ` Eli Zaretskii
2017-07-07  8:09               ` Nicolas Petton
2017-07-07 15:53               ` Stefan Monnier
2017-07-09 14:45                 ` Tino Calancha
2017-07-10 12:04                   ` Michael Heerdegen
2017-07-10 12:28                     ` Tino Calancha
2017-07-10 12:38                       ` Michael Heerdegen
2017-07-10 12:47                   ` Michael Heerdegen
2017-07-10 13:02                     ` Tino Calancha
2017-07-10 13:18                       ` Michael Heerdegen
2017-07-10 12:50               ` Michael Heerdegen
2017-07-06 14:56       ` Nicolas Petton
2017-07-07  6:39         ` Tino Calancha
2017-07-07  8:11           ` Nicolas Petton
2017-07-07  8:22             ` Tino Calancha
2017-07-07  8:34               ` Nicolas Petton
2017-07-07 15:49                 ` Stefan Monnier
2017-07-07 15:54                   ` Nicolas Petton
2017-07-07 19:47                   ` Nicolas Petton
2017-07-08  6:30                     ` Eli Zaretskii
2017-07-08  7:02                       ` Tino Calancha
2017-07-08  7:14                         ` Eli Zaretskii
2017-07-08 11:32                           ` Nicolas Petton
2017-07-08 11:46                             ` Eli Zaretskii
2017-07-09 14:48                               ` Tino Calancha
2017-07-09 19:18                               ` Nicolas Petton
2017-07-11  8:08                               ` Nicolas Petton
2017-07-11  9:19                                 ` Tino Calancha
2017-07-12 17:36                                   ` Michael Heerdegen
2017-07-14  5:19                                     ` Tino Calancha
2017-07-14 11:16                                       ` Nicolas Petton
2017-07-17 13:38                                         ` Tino Calancha
2017-08-01 16:37                                 ` Nicolas Petton
2017-08-01 16:49                                   ` Nicolas Petton
2017-08-01 18:53                                     ` Eli Zaretskii [this message]
2017-07-08 11:29                         ` Nicolas Petton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r2wvyv9y.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=27584@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=nicolas@petton.fr \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.