From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: JSON/YAML/TOML/etc. parsing performance Date: Sun, 08 Oct 2017 21:42:33 +0300 Message-ID: <83r2udscpy.fsf@gnu.org> References: <87poaqhc63.fsf@lifelogs.com> <8360ceh5f1.fsf@gnu.org> <83h8vl5lf9.fsf@gnu.org> <83r2um3fqi.fsf@gnu.org> <43520b71-9e25-926c-d744-78098dad6441@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507488220 10105 195.159.176.226 (8 Oct 2017 18:43:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 8 Oct 2017 18:43:40 +0000 (UTC) Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 08 20:43:35 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1GXx-00015B-Jz for ged-emacs-devel@m.gmane.org; Sun, 08 Oct 2017 20:43:29 +0200 Original-Received: from localhost ([::1]:54680 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1GY3-0004FF-7K for ged-emacs-devel@m.gmane.org; Sun, 08 Oct 2017 14:43:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1GXH-0004F9-BD for emacs-devel@gnu.org; Sun, 08 Oct 2017 14:42:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1GXE-00042g-PM for emacs-devel@gnu.org; Sun, 08 Oct 2017 14:42:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1GXE-00042a-LL; Sun, 08 Oct 2017 14:42:44 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4295 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e1GXD-0001bg-3f; Sun, 08 Oct 2017 14:42:44 -0400 In-reply-to: (message from Philipp Stephani on Sun, 08 Oct 2017 17:58:14 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219264 Archived-At: > From: Philipp Stephani > Date: Sun, 08 Oct 2017 17:58:14 +0000 > Cc: emacs-devel@gnu.org > > I've attached a new patch (which currently segfaults on decode_coding_gap, but the call to that function > doesn't seem to be required anyway). I think decode_coding_gap might segfault because you use insert_1_both to put the text into the buffer. By contrast, decode_coding_gap assumes you've copied the bytes into the gap, like we do in Finsert_file_contents. I don't think we can bypass decoding in this case; the reason why you think it isn't needed is because you only tried that with valid UTF-8 encoded text. We never rely on that elsewhere, AFAIK.