all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 30675@debbugs.gnu.org, jidanni@jidanni.org
Subject: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size
Date: Fri, 13 Apr 2018 12:29:17 +0300	[thread overview]
Message-ID: <83r2nj5uaa.fsf@gnu.org> (raw)
In-Reply-To: <87h8ogar2w.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Fri, 13 Apr 2018 02:27:19 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Fri, 13 Apr 2018 02:27:19 +0200
> Cc: 30675@debbugs.gnu.org
> 
> 積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
> 
> >>>>>> "LI" == Lars Ingebrigtsen <larsi@gnus.org> writes:
> >
> > LI> Or perhaps shr should just bind that variable to, like, 10x what it
> > LI> normally is?
> >
> > You're the boss.
> 
> No, I'm not.  Eli is.  :-)

I am?  Well, if I need to give my opinion on this, then blindly
increasing the limit ten-fold is something that'd make me worry about
a potential C stack overflow.  I'd feel much better with a lower
factor, e.g. some value that is just enough to cover this case plus
some slack.  Bonus points for providing a defcustom with the factor,
so that users could change that.

The idea of asking the user whether to increase by N levels sounds OK
to me, provided that its implementation is not out-worldly hard.

Thanks.





  reply	other threads:[~2018-04-13  9:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <877eqwbqvc.fsf@jidanni.org>
     [not found] ` <b4mfu5kk0iz.fsf@jpl.org>
2018-03-02  2:40   ` bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size 積丹尼 Dan Jacobson
2018-03-02  2:51     ` Noam Postavsky
2018-04-12 23:49     ` Lars Ingebrigtsen
2018-04-13  0:06       ` 積丹尼 Dan Jacobson
2018-04-13  0:27         ` Lars Ingebrigtsen
2018-04-13  9:29           ` Eli Zaretskii [this message]
2018-04-13 11:48             ` Lars Ingebrigtsen
2018-04-13 12:15               ` Noam Postavsky
2018-04-13 12:32                 ` Lars Ingebrigtsen
2018-04-13 12:43               ` Eli Zaretskii
2018-04-13 15:34                 ` Lars Ingebrigtsen
2018-04-15 17:02                   ` Lars Ingebrigtsen
2018-04-13 12:40             ` 積丹尼 Dan Jacobson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r2nj5uaa.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30675@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.