bug#31169: 26.1; Emacs 26.1 RC1 (gtk) display issues over SSH/X11 with xming/vcxsrv

[Eli Zaretskii <eliz@gnu.org>]

> From: Noam Postavsky <npostavs@gmail.com>
> Cc: 31169@debbugs.gnu.org,  charliehemlock@gmail.com
> Date: Fri, 20 Apr 2018 09:11:51 -0400
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Ah, `fancy-splash-frame' checks `frame-visible-p', which, for my window
> >> manager, depends on when I switch to the workspace.
> >
> > Is that a necessary test?  What happens if you use the selected frame,
> > when no frame is found to be visible?
> 
> Seems to be unnecessary: if I comment out the frame-visible-p check, I
> get the fancy splash regardless of when I switch workspace, and I see no
> bad side effects.

So I guess we could simply fall back to the selected frame if no frame
is visible.  I wouldn't remove the test or fancy-splash-frame
entirely, because there could be several frames to choose from, and
this same code runs when the user invokes about-emacs in the middle of
a session.

> Maybe that means this part would also be unneeded:
> 
>   (defun fancy-splash-frame ()
>     [...]
>     ;; MS-Windows needs this to have a chance to make the initial
>     ;; frame visible.
>     (if (eq (window-system) 'w32)
>         (sit-for 0 t))

If we were removing the visibility test, yes.