From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31837: 26.1; replace-buffer-contents doesn't work if buffer has multibyte characters Date: Tue, 19 Jun 2018 05:30:29 +0300 Message-ID: <83r2l3se2i.fsf@gnu.org> References: <7dm4li5jbmk.fsf@janestreet.com> <83tvq41m9r.fsf@gnu.org> <83sh5krmd1.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1529378610 21015 195.159.176.226 (19 Jun 2018 03:23:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Jun 2018 03:23:30 +0000 (UTC) Cc: 31837@debbugs.gnu.org To: Milan =?UTF-8?Q?Stanojevi=C4=87?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 19 05:23:25 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV7Ep-0005K6-92 for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jun 2018 05:23:23 +0200 Original-Received: from localhost ([::1]:39021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV7Gw-0005ur-BT for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jun 2018 23:25:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV6QD-0003Vu-Nl for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 22:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV6QA-00033q-Ir for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 22:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47716) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV6QA-00033P-EY for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 22:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fV6QA-0008ES-2f for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 22:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jun 2018 02:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31837 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31837-submit@debbugs.gnu.org id=B31837.152937543931616 (code B ref 31837); Tue, 19 Jun 2018 02:31:02 +0000 Original-Received: (at 31837) by debbugs.gnu.org; 19 Jun 2018 02:30:39 +0000 Original-Received: from localhost ([127.0.0.1]:55613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV6Pm-0008Ds-RE for submit@debbugs.gnu.org; Mon, 18 Jun 2018 22:30:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV6Pl-0008Df-Cx for 31837@debbugs.gnu.org; Mon, 18 Jun 2018 22:30:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV6Pd-0002d4-3f for 31837@debbugs.gnu.org; Mon, 18 Jun 2018 22:30:32 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV6Pc-0002cp-VV; Mon, 18 Jun 2018 22:30:29 -0400 Original-Received: from [176.228.60.248] (port=1664 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fV6Pc-0006oZ-Cj; Mon, 18 Jun 2018 22:30:28 -0400 In-reply-to: (message from Milan =?UTF-8?Q?Stanojevi=C4=87?= on Mon, 18 Jun 2018 16:29:41 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147621 Archived-At: > From: Milan Stanojević > Date: Mon, 18 Jun 2018 16:29:41 -0400 > Cc: 31837@debbugs.gnu.org > > If we do care about optimizing it, then it is better to check whether > the buffer actually contains multibyte characters (I guess with > BUF_Z(buf) == BUF_Z_BYTE(buf)) than using enable_multibyte_characters > since the the former would catch strictly more cases when we don't > need charpos to bytepos conversion. No, testing BUF_Z vs BUF_Z_BYTE cannot possibly catch more cases, because multibyte characters cannot happen in a buffer whose enable_multibyte_characters is reset, and any unibyte buffer's Z value is trivially equal to its Z_BYTE value. > Also, it occurs to me, the check shouldn't be done in > buffer_chars_equal, since the same check would be done multiple times > for a single character (for every comparison of that character), it > should be done once and the result stored in ctx before calling > compareseq. Something to consider if further optimization is needed.