From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11732: Follow-up to bug#11732 Date: Sun, 01 Jul 2018 17:34:24 +0300 Message-ID: <83r2knkosv.fsf@gnu.org> References: <87obohkxga.fsf@XAVIER-PC.i-did-not-set--mail-host-address--so-tickle-me> <83y3f0p6n7.fsf@gnu.org> <5B35F120.9040807@gmx.at> <83fu16nepn.fsf@gnu.org> <5B373A21.9050407@gmx.at> <83d0w8mrvu.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1530455590 8066 195.159.176.226 (1 Jul 2018 14:33:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 1 Jul 2018 14:33:10 +0000 (UTC) Cc: 11732@debbugs.gnu.org, mhatta@gmail.com To: rudalics@gmx.at Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 01 16:33:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZdPW-0001zj-5R for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2018 16:33:06 +0200 Original-Received: from localhost ([::1]:54602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZdRd-00050S-BH for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2018 10:35:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZdRR-00050L-7i for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 10:35:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZdRO-0002eu-4w for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 10:35:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZdRO-0002en-0t for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 10:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fZdRN-0001Xh-Qo for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 10:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jul 2018 14:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11732-submit@debbugs.gnu.org id=B11732.15304556865902 (code B ref 11732); Sun, 01 Jul 2018 14:35:01 +0000 Original-Received: (at 11732) by debbugs.gnu.org; 1 Jul 2018 14:34:46 +0000 Original-Received: from localhost ([127.0.0.1]:42232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZdR7-0001X8-M1 for submit@debbugs.gnu.org; Sun, 01 Jul 2018 10:34:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZdR5-0001Wv-HU for 11732@debbugs.gnu.org; Sun, 01 Jul 2018 10:34:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZdQz-0002XW-Ci for 11732@debbugs.gnu.org; Sun, 01 Jul 2018 10:34:38 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZdQv-0002WG-Jq; Sun, 01 Jul 2018 10:34:33 -0400 Original-Received: from [176.228.60.248] (port=4769 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fZdQv-0000xx-1N; Sun, 01 Jul 2018 10:34:33 -0400 In-reply-to: <83d0w8mrvu.fsf@gnu.org> (message from Eli Zaretskii on Sat, 30 Jun 2018 14:32:37 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148046 Archived-At: > Date: Sat, 30 Jun 2018 14:32:37 +0300 > From: Eli Zaretskii > Cc: 11732@debbugs.gnu.org, mhatta@gmail.com > > > > + if (msg == WM_NOTIFY) > > > + { > > > + SetWindowPos (hdlg, HWND_NOTOPMOST, 0, 0, 0, 0, > > > + SWP_NOMOVE | SWP_NOSIZE | SWP_NOACTIVATE > > > + | SWP_NOOWNERZORDER); > > > > The HWND_NOTOPMOST doesn't look good - dialog boxes should be topmost. > > Could you try with > > > > static UINT_PTR CALLBACK > > font_dialog_callback (HWND hdlg, UINT msg, WPARAM wParam, LPARAM lParam) > > { > > static HWND cf_hwnd; > > > > if (msg == WM_INITDIALOG) > > cf_hwnd = ((CHOOSEFONT *)lParam)->hwndOwner; > > > > if (msg == WM_NOTIFY) > > { > > SetWindowPos (hdlg, HWND_TOPMOST, 0, 0, 0, 0, > > SWP_NOMOVE | SWP_NOSIZE | SWP_NOOWNERZORDER); > > SetWindowPos (cf_hwnd, hdlg, 0, 0, 0, 0, SWP_NOMOVE | SWP_NOSIZE > > | SWP_NOACTIVATE); > > } > > return 0; > > } > > This looks good on XP, I will try on Windows 7 later. Curiously, > HWND_TOPMOST here doesn't prevent raising other windows above the > dialog box, as it does with file selector. > > > It doesn't show any strange effects here, at least. > > I think the problems I saw were on Windows 7. Will check. Tested the above on Windows 7. Seems to work well, with 2 caveats: . The dialog and its frame are raised to be topmost, so no other application window can be put above them, something that the current code allows. Not sure if this will annoy people. . The font selection dialog looks somewhat differently on Windows 7 from the dialog shown by the existing code -- the layout is slightly different, and the link "Show more fonts" is not there. Unless you have some new ideas about the problem, given what I described in my other message, I guess we should disregard the problems that somehow only I can reproduce, and go with the original change. It would be nice to avoid the problems I have, but if not, they are not critical and shouldn't block the main issue of this bug report. Thanks.