From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34723: 27.0.50; customize and improve diff-mode recentering Date: Tue, 05 Mar 2019 21:44:01 +0200 Message-ID: <83r2blcdj2.fsf@gnu.org> References: <8336o1e33w.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="73495"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34723@debbugs.gnu.org To: charles@aurox.ch Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 05 20:45:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1G0E-000J2J-Uw for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Mar 2019 20:45:27 +0100 Original-Received: from localhost ([127.0.0.1]:48377 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1G0D-0003B8-Vf for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Mar 2019 14:45:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1G07-0003An-Sa for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 14:45:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1G01-0008BW-9g for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 14:45:15 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48165) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1Fzp-00080t-UK for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 14:45:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1Fzp-0006Di-LC for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 14:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Mar 2019 19:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34723 X-GNU-PR-Package: emacs Original-Received: via spool by 34723-submit@debbugs.gnu.org id=B34723.155181505323833 (code B ref 34723); Tue, 05 Mar 2019 19:45:01 +0000 Original-Received: (at 34723) by debbugs.gnu.org; 5 Mar 2019 19:44:13 +0000 Original-Received: from localhost ([127.0.0.1]:33476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1Fz1-0006CK-Ja for submit@debbugs.gnu.org; Tue, 05 Mar 2019 14:44:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1Fz0-0006C8-8M for 34723@debbugs.gnu.org; Tue, 05 Mar 2019 14:44:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Fyu-0006mG-Db; Tue, 05 Mar 2019 14:44:04 -0500 Original-Received: from [176.228.60.248] (port=4375 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h1Fyu-0006fy-0W; Tue, 05 Mar 2019 14:44:04 -0500 In-reply-to: (charles@aurox.ch) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156067 Archived-At: > Date: Tue, 05 Mar 2019 20:49:13 +0100 > From: charles@aurox.ch (Charles A. Roelli) > CC: 34723@debbugs.gnu.org > > The function diff-hunk-next is defined using the macro > easy-mmode-define-navigation, and its definition calls (recenter '(0)) > too liberally. The call also ignores settings like > 'scroll-conservatively'. The display engine is not at fault, and we > should be able to fix the issue either in easy-mmode or in diff-mode. I don't understand what calling 'recenter' has to do with scroll-conservatively. And scroll-conservatively is implemented in the display engine, so I'm afraid I'm still in the dark regarding the nature of the problem you are discussing. Of course, if you know what to do to fix the problem, there's no need for me to understand the issue, and I should just shut up and let you do what you think is right. Thanks.