From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31138: Native json slower than json.el Date: Sun, 24 Mar 2019 17:15:43 +0200 Message-ID: <83r2awnw0w.fsf@gnu.org> References: <87sh806xwa.fsf@chapu.is> <834lkf7ely.fsf@gnu.org> <878t9own1p.fsf@chapu.is> <838t9o4hvl.fsf@gnu.org> <83r2ayovkx.fsf@gnu.org> <83pnqiormy.fsf@gnu.org> <83lg15pvzr.fsf@gnu.org> <83k1gppu73.fsf@gnu.org> <83ftrdprmj.fsf@gnu.org> <83d0mhpn99.fsf@gnu.org> <83zhplo25s.fsf@gnu.org> <83va09nwg3.fsf@gnu.org> <83tvftne0j.fsf@gnu.org> <40DA9396-044E-4D00-946E-42B776B51BFA@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="224329"; mail-complaints-to="usenet@blaine.gmane.org" Cc: sebastien@chapu.is, 31138@debbugs.gnu.org To: yyoncho Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 24 16:28:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h852r-000wC5-1p for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 16:28:21 +0100 Original-Received: from localhost ([127.0.0.1]:57461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h852q-0005Ky-1u for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 11:28:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h851r-0004Hv-7G for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:27:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h84qx-0004zQ-Tr for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:16:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43396) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h84qw-0004ve-I6 for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h84qw-0006o2-D9 for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Mar 2019 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31138-submit@debbugs.gnu.org id=B31138.155344055025444 (code B ref 31138); Sun, 24 Mar 2019 15:16:02 +0000 Original-Received: (at 31138) by debbugs.gnu.org; 24 Mar 2019 15:15:50 +0000 Original-Received: from localhost ([127.0.0.1]:56939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h84qj-0006c3-Tp for submit@debbugs.gnu.org; Sun, 24 Mar 2019 11:15:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h84qi-0006Uw-CW for 31138@debbugs.gnu.org; Sun, 24 Mar 2019 11:15:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h84qc-0004gY-U0; Sun, 24 Mar 2019 11:15:42 -0400 Original-Received: from [176.228.60.248] (port=4509 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h84qc-0006U6-9R; Sun, 24 Mar 2019 11:15:42 -0400 In-reply-to: (message from yyoncho on Sun, 24 Mar 2019 13:37:23 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156705 Archived-At: > From: yyoncho > Date: Sun, 24 Mar 2019 13:37:23 +0200 > Cc: Sébastien Chapuis , > 31138@debbugs.gnu.org > > After code_convert_string_norecord the callstack is the same as the callstack of the JSON parsing (it uses > the same method to convert/validate the string). Got it, thanks. Please try the patch below and see if it solves the problem in both cases. diff --git a/src/coding.c b/src/coding.c index 905c7ce..f9c9dc8 100644 --- a/src/coding.c +++ b/src/coding.c @@ -7807,10 +7807,14 @@ make_conversion_work_buffer (bool multibyte) Lisp_Object name, workbuf; struct buffer *current; + current = current_buffer; if (reused_workbuf_in_use) { name = Fgenerate_new_buffer_name (Vcode_conversion_workbuf_name, Qnil); workbuf = Fget_buffer_create (name); + set_buffer_internal (XBUFFER (workbuf)); + Fset (Fmake_local_variable (Qkill_buffer_query_functions), Qnil); + Fset (Fmake_local_variable (Qkill_buffer_hook), Qnil); } else { @@ -7819,9 +7823,8 @@ make_conversion_work_buffer (bool multibyte) Vcode_conversion_reused_workbuf = Fget_buffer_create (Vcode_conversion_workbuf_name); workbuf = Vcode_conversion_reused_workbuf; + set_buffer_internal (XBUFFER (workbuf)); } - current = current_buffer; - set_buffer_internal (XBUFFER (workbuf)); /* We can't allow modification hooks to run in the work buffer. For instance, directory_files_internal assumes that file decoding doesn't compile new regexps. */