all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alex <agrambot@gmail.com>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Increase minimum required GTK versions?
Date: Fri, 12 Apr 2019 21:49:54 +0300	[thread overview]
Message-ID: <83r2a7kqi6.fsf@gnu.org> (raw)
In-Reply-To: <87tvf5tm4f.fsf@gmail.com> (message from Alex on Wed, 10 Apr 2019 18:35:12 -0600)

> From: Alex <agrambot@gmail.com>
> Cc: monnier@iro.umontreal.ca,  emacs-devel@gnu.org
> Date: Wed, 10 Apr 2019 18:35:12 -0600
> 
> >> * Old file selection dialog
> >> This is only optionally used in GTK 2, but the old dialog is long
> >> deprecated in GTK 2 (removed in GTK 3), so I figured that this is a good
> >> time to remove it and simplify the existing code.
> >
> > I think this should be left alone.  It's a separate issue anyway, and
> > should be submitted separately.  It would be good to try to establish
> > whether this feature is turned on by someone, but given that it's only
> > for GTK2, I tend to think we should simply let it die a natural death
> > together with GTK2.
> 
> Okay, done.

Are you sure?  I still see the code related to this being removed.

> I've attached an updated patch.

Fine with me, modulo the file dialog stuff.

Thanks.



  parent reply	other threads:[~2019-04-12 18:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-07 19:03 Increase minimum required GTK versions? Alex
2019-04-07 19:08 ` Eli Zaretskii
2019-04-07 19:25   ` Alex
2019-04-08  4:45     ` Paul Eggert
2019-04-08 15:03       ` Alex
2019-04-08 16:03         ` Kaushal Modi
2019-04-08 16:15         ` Glenn Morris
2019-04-08 23:58           ` Paul Eggert
2019-04-09  1:55             ` Stefan Monnier
2019-04-09  4:47               ` Paul Eggert
2019-04-09 17:28                 ` Alex
2019-04-09 18:21                   ` Eli Zaretskii
2019-04-10  3:14                     ` Alex
2019-04-10 15:57                       ` Eli Zaretskii
2019-04-10 16:20                         ` Stefan Monnier
2019-04-10 16:43                           ` Eli Zaretskii
2019-04-11  0:35                         ` Alex
2019-04-11  1:26                           ` Alex Branham
2019-04-11 14:19                             ` Eli Zaretskii
2019-04-11 14:26                               ` Dmitry Gutov
2019-04-11 14:29                               ` Alex
2019-04-12 18:49                           ` Eli Zaretskii [this message]
2019-04-12 19:05                             ` Alex Gramiak
2019-04-12 19:14                               ` Eli Zaretskii
2019-04-12 19:33                                 ` Alex Gramiak
2019-04-12 19:45                                   ` Eli Zaretskii
2019-04-12 20:04                                     ` Alex Gramiak
2019-04-12 20:17                                       ` Eli Zaretskii
2019-04-09  5:00               ` Van L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r2a7kqi6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=agrambot@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.