From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Fri, 03 May 2019 16:44:52 +0300 Message-ID: <83r29fmz3f.fsf@gnu.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="12418"; mail-complaints-to="usenet@blaine.gmane.org" Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 03 23:18:03 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMfZ5-0017On-CD for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 May 2019 23:17:55 +0200 Original-Received: from localhost ([127.0.0.1]:40988 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMYVu-0001YM-F5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 May 2019 09:46:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMYVn-0001TL-8F for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 09:46:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMYVm-0003sF-3l for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 09:46:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34569) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMYVm-0003rD-05 for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 09:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMYVl-0006y8-RC for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 09:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2019 13:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155689113026750 (code B ref 35418); Fri, 03 May 2019 13:46:01 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 3 May 2019 13:45:30 +0000 Original-Received: from localhost ([127.0.0.1]:48113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMYVG-0006xO-Do for submit@debbugs.gnu.org; Fri, 03 May 2019 09:45:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMYVF-0006xC-1K for 35418@debbugs.gnu.org; Fri, 03 May 2019 09:45:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMYV8-0002zu-M9; Fri, 03 May 2019 09:45:23 -0400 Original-Received: from [176.228.60.248] (port=4987 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMYV7-0003hD-S4; Fri, 03 May 2019 09:45:22 -0400 In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Thu, 02 May 2019 14:53:20 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158710 Archived-At: > From: Mattias Engdegård > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > Date: Thu, 02 May 2019 14:53:20 +0200 > > * doc/emacs/files.texi: > * doc/emacs/arevert-xtra.texi: > * doc/emacs/buffers.texi: > * doc/emacs/emacs.texi: > * doc/emacs/emacs-xtra.texi: > Add node 'Auto-revert' and move general information on that topic there. > Sort paragraphs in that node in a rough least-to-most specific order. > Include the old 'Autorevert' node into that node when building the > on-line manual. It is better to cite the node names in the log, unless doing that is completely impractical. > diff --git a/doc/emacs/arevert-xtra.texi b/doc/emacs/arevert-xtra.texi > index cd7c1ff895..8cc5b053b5 100644 > --- a/doc/emacs/arevert-xtra.texi > +++ b/doc/emacs/arevert-xtra.texi > @@ -4,8 +4,7 @@ > @c > @c This file is included either in emacs-xtra.texi (when producing the > @c printed version) or in the main Emacs manual (for the on-line version). > -@node Autorevert > -@section Auto Reverting Non-File Buffers > +@c The including file must provide its own @node and @section lines. So maybe we shouldn't remove the @node here? How about making it a subsection of "Auto Revert" instead? > +@vindex auto-revert-remote-files > + These minor modes do not check or revert remote files, because that is Which "these minor modes"? Such wording is only appropriate when it closely follows a list of modes, which is not the case here. I think it's better to enumerate the modes explicitly here. > +usually too slow. This behavior can be changed by setting the > +variable @code{auto-revert-remote-files} to non-@code{nil}. > > @cindex file notifications > @vindex auto-revert-use-notify > - By default, Auto-Revert mode works using @dfn{file notifications}, > +@vindex auto-revert-interval > + By default, Auto Revert mode works using @dfn{file notifications}, > whereby changes in the filesystem are reported to Emacs by the OS. > You can disable use of file notifications by customizing the variable > @code{auto-revert-use-notify} to a @code{nil} value, then Emacs will > @@ -990,7 +1010,7 @@ Reverting > > @vindex auto-revert-avoid-polling > @vindex auto-revert-notify-exclude-dir-regexp > - By default, Auto-Revert mode will poll files for changes > + By default, Auto Revert mode will poll files for changes > periodically even when file notifications are used. Such polling is > usually unnecessary, and turning it off may save power by relying on ^^^^^^^^^^^^^^^^^^^ I would say "unnecessary in many cases". "usually" begs the question why by default we do poll. Bonus points for adding some hint about what rare situations do need such polling, as I think this description sounds like a small riddle without that, and doesn't allow people to make an educated decision regarding whether they do or don't want the polling turned off. Thanks.