From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: eggert@cs.ucla.edu, daniele@grinta.net, emacs-devel@gnu.org
Subject: Re: `message' not outputting the newline "atomically"
Date: Tue, 25 Jun 2019 19:03:34 +0300 [thread overview]
Message-ID: <83r27hlkix.fsf@gnu.org> (raw)
In-Reply-To: <m37e9ak3db.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 25 Jun 2019 00:47:12 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 25 Jun 2019 00:47:12 +0200
> Cc: Daniele Nicolodi <daniele@grinta.net>, emacs-devel@gnu.org
>
> I'm pushing the current version I have now, so we can tinker with it
> more collaboratively.
There was no reason to rush this to the repository. Paul raises valid
concerns, some of which I had as well. Also, the commit message
describes something that is very different from the code that was
actually pushed.
I think a version with a fixed-size automatic buffer and a loop using
it to write the message in chunks, would be a much cleaner solution
than allocating the buffer off the heap.
There's also a possibility to use the null byte that we
always/normally have in strings after the last byte. 'fwrite' doesn't
need it, so we could replace it with a newline, write the message,
then replace the newline back with the null byte. This is somewhat
hacky, but it eliminates the need for a buffer and a loop.
next prev parent reply other threads:[~2019-06-25 16:03 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 14:12 `message' not outputting the newline "atomically" Lars Ingebrigtsen
2019-06-19 14:28 ` Andreas Schwab
2019-06-19 15:41 ` Eli Zaretskii
2019-06-19 15:47 ` Lars Ingebrigtsen
2019-06-19 16:05 ` Andreas Schwab
2019-06-19 23:22 ` Paul Eggert
2019-06-20 2:35 ` Eli Zaretskii
2019-06-20 7:47 ` Paul Eggert
2019-06-20 9:35 ` Lars Ingebrigtsen
2019-06-20 12:52 ` Eli Zaretskii
2019-06-20 12:55 ` Lars Ingebrigtsen
2019-06-20 13:13 ` Eli Zaretskii
2019-06-20 14:05 ` Andreas Schwab
2019-06-20 16:26 ` Paul Eggert
2019-06-20 16:45 ` Eli Zaretskii
2019-06-20 17:41 ` Paul Eggert
2019-06-20 18:06 ` Eli Zaretskii
2019-06-20 19:33 ` Paul Eggert
2019-06-21 5:46 ` Eli Zaretskii
2019-06-21 6:06 ` Eli Zaretskii
2019-06-22 0:20 ` Paul Eggert
2019-06-22 7:32 ` Eli Zaretskii
2019-06-22 19:14 ` Paul Eggert
2019-06-23 2:25 ` Eli Zaretskii
2019-06-23 8:34 ` Paul Eggert
2019-06-23 11:37 ` Lars Ingebrigtsen
2019-06-23 14:47 ` Eli Zaretskii
2019-06-23 17:32 ` Paul Eggert
2019-06-23 18:28 ` Eli Zaretskii
2019-06-23 12:53 ` Stefan Monnier
2019-06-23 14:51 ` Eli Zaretskii
2019-06-24 4:09 ` Stefan Monnier
2019-06-22 8:26 ` Andreas Schwab
2019-06-22 18:53 ` Paul Eggert
2019-06-22 19:00 ` Eli Zaretskii
2019-06-22 19:15 ` Paul Eggert
2019-06-22 19:48 ` Andreas Schwab
2019-06-20 13:32 ` Stefan Monnier
2019-06-20 16:28 ` Paul Eggert
2019-06-23 18:59 ` Daniele Nicolodi
2019-06-23 20:34 ` Paul Eggert
2019-06-23 20:42 ` Lars Ingebrigtsen
2019-06-23 21:00 ` Paul Eggert
2019-06-23 22:18 ` Lars Ingebrigtsen
2019-06-23 20:48 ` Daniele Nicolodi
2019-06-24 2:32 ` Eli Zaretskii
2019-06-24 2:51 ` HaiJun Zhang
2019-06-24 19:48 ` Lars Ingebrigtsen
2019-06-24 20:03 ` Daniele Nicolodi
2019-06-24 20:17 ` Lars Ingebrigtsen
2019-06-24 21:11 ` Paul Eggert
2019-06-24 21:33 ` Lars Ingebrigtsen
2019-06-24 22:03 ` Paul Eggert
2019-06-24 22:06 ` Paul Eggert
2019-06-24 22:28 ` Lars Ingebrigtsen
2019-06-24 22:47 ` Lars Ingebrigtsen
2019-06-25 16:03 ` Eli Zaretskii [this message]
2019-06-26 9:15 ` Lars Ingebrigtsen
2019-06-26 15:22 ` Eli Zaretskii
2019-06-27 10:52 ` Lars Ingebrigtsen
2019-06-26 18:27 ` Paul Eggert
2019-06-26 18:41 ` Eli Zaretskii
2019-06-26 18:58 ` Paul Eggert
2019-06-26 19:11 ` Eli Zaretskii
2019-06-26 19:36 ` Daniele Nicolodi
2019-06-27 2:34 ` Eli Zaretskii
2019-06-27 5:43 ` Paul Eggert
2019-06-30 20:11 ` Daniele Nicolodi
2019-07-01 7:41 ` Daniele Nicolodi
2019-07-01 14:39 ` Eli Zaretskii
2019-07-01 17:01 ` Daniele Nicolodi
2019-07-02 2:28 ` Eli Zaretskii
2019-07-02 7:58 ` Daniele Nicolodi
2019-07-02 14:47 ` Eli Zaretskii
2019-07-02 20:56 ` Daniele Nicolodi
2019-07-03 5:23 ` Eli Zaretskii
2019-07-01 17:03 ` Daniele Nicolodi
2019-07-02 2:26 ` Eli Zaretskii
2019-06-26 19:38 ` Paul Eggert
2019-06-25 16:06 ` Eli Zaretskii
2019-06-26 9:21 ` Lars Ingebrigtsen
2019-06-26 15:23 ` Eli Zaretskii
2019-06-27 11:03 ` Lars Ingebrigtsen
2019-06-27 13:31 ` Eli Zaretskii
2019-06-28 8:30 ` Lars Ingebrigtsen
2019-07-03 7:31 ` Paul Eggert
2019-07-03 7:41 ` Eli Zaretskii
2019-07-03 7:47 ` Eli Zaretskii
2019-07-03 7:57 ` Eli Zaretskii
2019-07-03 8:45 ` Paul Eggert
2019-07-03 9:30 ` Eli Zaretskii
2019-07-03 23:08 ` Paul Eggert
2019-07-04 13:24 ` Eli Zaretskii
2019-07-07 1:16 ` Paul Eggert
2019-07-07 14:51 ` Eli Zaretskii
2019-07-08 22:35 ` Richard Copley
2019-07-09 2:33 ` Eli Zaretskii
2019-07-09 13:45 ` Richard Copley
2019-07-09 15:16 ` Eli Zaretskii
2019-07-09 2:47 ` Paul Eggert
2019-07-09 16:39 ` Eli Zaretskii
2019-07-09 18:12 ` Paul Eggert
2019-07-09 18:32 ` Eli Zaretskii
2019-07-09 18:44 ` Lars Ingebrigtsen
2019-07-09 19:17 ` Eli Zaretskii
2019-07-14 0:42 ` Paul Eggert
2019-07-14 6:01 ` Eli Zaretskii
2019-06-25 16:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r27hlkix.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=daniele@grinta.net \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.