all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com
Subject: bug#36803: 27.0.50; Update mode-line of every window when compilation ends
Date: Fri, 26 Jul 2019 11:13:12 +0300	[thread overview]
Message-ID: <83r26dmcx3.fsf@gnu.org> (raw)
In-Reply-To: <83ef2enosr.fsf@gnu.org> (message from Eli Zaretskii on Thu, 25 Jul 2019 17:59:00 +0300)

> Date: Thu, 25 Jul 2019 17:59:00 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 36803@debbugs.gnu.org, larsi@gnus.org
> 
> > If my bisection is correct, then this regression dates back from
> > 
> >     645c8597e7f9fbc90ffe227d2be8ce383b0777ae
> >     * src/process.c (status_notify): Avoid global redisplay (bug#11822)
> >     http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=645c8597e7f9fbc90ffe227d2be8ce383b0777ae
> 
> Makes sense, I will look into why this change was made.

Stefan, I'm looking and looking, and don't understand why that change
made sense.  The process-status indication in the mode line is shown
in all windows, so status_notify is exactly the place where we should
trigger update of all mode lines.  Otherwise, we will have to sprinkle
force-mode-line-update calls all over the place (and it still won't
work well in the cases where the default sentinel is used, and this no
Lisp is involved).

So I think we should restore the old code, i.e. revert this part of
the above-mentioned commit:

  --- a/src/process.c
  +++ b/src/process.c
  @@ -6694,10 +6694,12 @@ status_notify (struct Lisp_Process *deleting_process,
	    p->update_tick = p->tick;
	    /* Now output the message suitably.  */
	    exec_sentinel (proc, msg);
  +         if (BUFFERP (p->buffer))
  +           /* In case it uses %s in mode-line-format.  */
  +           bset_update_mode_line (XBUFFER (p->buffer));
	  }
       } /* end for */

  -  update_mode_lines = 24;  /* In case buffers use %s in mode-line-format.  */
     return got_some_output;
   }

Am I missing something?





  reply	other threads:[~2019-07-26  8:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24 21:22 bug#36803: 27.0.50; Update mode-line of every window when compilation ends Kévin Le Gouguec
2019-07-25  9:42 ` Lars Ingebrigtsen
2019-07-25 10:34   ` Eli Zaretskii
2019-07-25 13:37     ` Kévin Le Gouguec
2019-07-25 14:59       ` Eli Zaretskii
2019-07-26  8:13         ` Eli Zaretskii [this message]
2019-07-26 13:59           ` Stefan Monnier
2019-07-26 15:08             ` Eli Zaretskii
2019-07-26 16:23               ` Stefan Monnier
2019-07-26 18:16                 ` Eli Zaretskii
2019-07-26 18:53                   ` Stefan Monnier
2019-07-26 19:21                     ` Eli Zaretskii
2019-07-26 19:35                       ` Lars Ingebrigtsen
2019-07-26 21:26                         ` Kévin Le Gouguec
2019-07-27  9:53                           ` Lars Ingebrigtsen
2019-07-27 17:01                             ` Kévin Le Gouguec
2019-07-27  6:57                         ` Eli Zaretskii
2019-07-26 21:10                       ` Stefan Monnier
2019-07-27  7:46                         ` Eli Zaretskii
2019-07-27 12:46                           ` Stefan Monnier
2019-07-27 13:12                             ` Eli Zaretskii
2019-07-27 14:00                               ` Stefan Monnier
2019-07-27 17:37                                 ` Kévin Le Gouguec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r26dmcx3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=36803@debbugs.gnu.org \
    --cc=kevin.legouguec@gmail.com \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.