all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: lennart.borgman@gmail.com, 6411@debbugs.gnu.org
Subject: bug#6411: Ispell string or comment
Date: Wed, 21 Aug 2019 20:08:29 +0300	[thread overview]
Message-ID: <83r25ejvjm.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmkv-Kz2gPnAR=K-EkbKprBkTWZG8H1htcV2HywVnvxy_g@mail.gmail.com> (message from Stefan Kangas on Wed, 21 Aug 2019 16:07:53 +0200)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Wed, 21 Aug 2019 16:07:53 +0200
> Cc: 6411@debbugs.gnu.org
> 
> Lennart Borgman <lennart.borgman@gmail.com> writes:
> 
> > Here is a suggestion for a function ispell-comment-or-string for spell
> > checking of current comment or string, see attachement.
> 
> This patch from 2010 still applies on current master, and it seems to
> work as advertised from my minimal testing.  I think it would be a
> good addition.  Does anyone object to installing it?

Sorry, but I happen to think the proposed implementation is somewhat
inelegant:

  . what's with the "(interactive (list nil))" part?
  . why not just make ispell-comments-and-strings accept a prefix
    argument to modify its behavior?
  . alternatively, why not make ispell-comments-and-strings be
    sensitive to the active region?
  . as yet another alternative, make the new ispell-comment-or-string
    narrow to the comment/string at point and then call
    ispell-comments-and-strings with no code changes whatsoever; then
    make the new command be sensitive to active region, and fall back
    on the string/comment at point if no active region





  reply	other threads:[~2019-08-21 17:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-12 17:57 bug#6411: Ispell string or comment Lennart Borgman
2010-06-22 15:00 ` Agustin Martin
2019-08-21 14:07 ` Stefan Kangas
2019-08-21 17:08   ` Eli Zaretskii [this message]
2019-08-21 20:57     ` Stefan Kangas
2020-04-08 19:23     ` bug#6411: Ispell string or comment, " Štěpán Němec
2020-04-09  6:21       ` Eli Zaretskii
2020-04-09 14:48         ` Štěpán Němec
2020-04-09 17:06           ` Eli Zaretskii
2020-04-09 17:11             ` Eli Zaretskii
2020-04-09 18:44             ` Štěpán Němec
2020-04-09 19:01               ` Eli Zaretskii
2020-04-09 19:56                 ` Štěpán Němec
2020-04-10  6:22                   ` Eli Zaretskii
2020-08-26 11:27         ` Štěpán Němec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r25ejvjm.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=6411@debbugs.gnu.org \
    --cc=lennart.borgman@gmail.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.