From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37393: 26.2.90; [PATCH] Speed up 'csv-align-fields' Date: Tue, 17 Sep 2019 20:23:19 +0300 Message-ID: <83r24evnug.fsf@gnu.org> References: <5d810f73.1c69fb81.486b.2e0a@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="67273"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37393@debbugs.gnu.org, monnier@iro.umontreal.ca, sdl.web@gmail.com To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 17 19:24:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAHD0-000HNH-LS for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Sep 2019 19:24:10 +0200 Original-Received: from localhost ([::1]:48848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAHCz-0006A2-HH for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Sep 2019 13:24:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51850) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAHCt-00069k-Eh for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 13:24:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAHCs-0001LM-Gq for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 13:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44390) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iAHCs-0001LF-E6 for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 13:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iAHCs-0000vq-8J for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 13:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Sep 2019 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37393-submit@debbugs.gnu.org id=B37393.15687410113539 (code B ref 37393); Tue, 17 Sep 2019 17:24:02 +0000 Original-Received: (at 37393) by debbugs.gnu.org; 17 Sep 2019 17:23:31 +0000 Original-Received: from localhost ([127.0.0.1]:53211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAHCK-0000uz-U3 for submit@debbugs.gnu.org; Tue, 17 Sep 2019 13:23:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAHCI-0000ue-Q7 for 37393@debbugs.gnu.org; Tue, 17 Sep 2019 13:23:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iAHCD-00015l-DM; Tue, 17 Sep 2019 13:23:21 -0400 Original-Received: from [176.228.60.248] (port=3106 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iAHCC-0002nx-5x; Tue, 17 Sep 2019 13:23:20 -0400 In-reply-to: <5d810f73.1c69fb81.486b.2e0a@mx.google.com> (message from Simen =?UTF-8?Q?Heggest=C3=B8yl?= on Tue, 17 Sep 2019 18:53:06 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166652 Archived-At: > From: Simen Heggestøyl > Cc: 37393@debbugs.gnu.org, sdl.web@gmail.com > Date: Tue, 17 Sep 2019 18:53:06 +0200 > > > Maybe we could get yet more speedup by making it possible to pass to > > `current-column` (or a new C function) a start position along with its > > column, so we'd avoid re-traversing the part of the line that we've > > already processed. > > I think that sounds like a good idea; then my ugly "fast-current-column" > patch from last time won't be needed. Once again, risking to talk about something I don't clearly understand: vertical-motion already allows you to pass an argument which tells what is the current column. Any rationale to use current-column instead of vertical-motion?