From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37932: [PATCH] Support hidpi fringes and images with Cairo Date: Sat, 26 Oct 2019 12:14:19 +0300 Message-ID: <83r22zvpg4.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="114150"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37932@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 26 11:15:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOIAP-000TSf-Hi for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Oct 2019 11:15:25 +0200 Original-Received: from localhost ([::1]:39382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOIAO-0003Fo-5x for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Oct 2019 05:15:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54785) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOIA3-0002uX-IT for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 05:15:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOIA2-00047r-Ea for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 05:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59101) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iOIA2-00047j-Bj for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 05:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iOIA2-0005g7-5e for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 05:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Oct 2019 09:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37932-submit@debbugs.gnu.org id=B37932.157208127921776 (code B ref 37932); Sat, 26 Oct 2019 09:15:02 +0000 Original-Received: (at 37932) by debbugs.gnu.org; 26 Oct 2019 09:14:39 +0000 Original-Received: from localhost ([127.0.0.1]:39689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOI9e-0005f8-K7 for submit@debbugs.gnu.org; Sat, 26 Oct 2019 05:14:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOI9c-0005et-DT for 37932@debbugs.gnu.org; Sat, 26 Oct 2019 05:14:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iOI9W-0003z1-A3; Sat, 26 Oct 2019 05:14:30 -0400 Original-Received: from [176.228.60.248] (port=3776 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iOI9V-0004sU-QG; Sat, 26 Oct 2019 05:14:30 -0400 In-reply-to: (message from Carlos Pita on Sat, 26 Oct 2019 05:05:52 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170182 Archived-At: > From: Carlos Pita > Date: Sat, 26 Oct 2019 05:05:52 -0300 > > Here is an attempt to fix the above issues: > > https://github.com/memeplex/emacs/commit/473beb25dd947c34392708ca40f1b3bf80613007 Thanks, but please continue posting the patches to the bug tracker, so that the record of these discussions is complete. It would also make it easier for people to review the patches in Emacs while having instant and easy access to the current code. > * It removes the auto :scale property. I think this is the right thing > to do, applications that want to use the :scale parameter to transform > their images shouldn't lose the hidpi scaling nor explicitly call > image-compute-scaling-factor. I don't think I'm qualified to make an intelligent decision on this by myself (and you just asked the question not long ago, and proceeded to coding without giving anyone any time to answer it :-(). I don't know enough about this to make such a decision. maybe Robert, Alan, and others would chime in and voice their opinions. failing that, please tell more about the pro's and con's here, so that we could see what kind of trade-offs are we talking about. Thanks.