From: Eli Zaretskii <eliz@gnu.org>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: 37932@debbugs.gnu.org
Subject: bug#37932: [PATCH] Support hidpi fringes and images with Cairo
Date: Sat, 26 Oct 2019 12:14:19 +0300 [thread overview]
Message-ID: <83r22zvpg4.fsf@gnu.org> (raw)
In-Reply-To: <CAELgYhcfvXWheh6-JdLy8UbiBec2hB1Fu-YFFkORo-FCG1jFWQ@mail.gmail.com> (message from Carlos Pita on Sat, 26 Oct 2019 05:05:52 -0300)
> From: Carlos Pita <carlosjosepita@gmail.com>
> Date: Sat, 26 Oct 2019 05:05:52 -0300
>
> Here is an attempt to fix the above issues:
>
> https://github.com/memeplex/emacs/commit/473beb25dd947c34392708ca40f1b3bf80613007
Thanks, but please continue posting the patches to the bug tracker, so
that the record of these discussions is complete. It would also make
it easier for people to review the patches in Emacs while having
instant and easy access to the current code.
> * It removes the auto :scale property. I think this is the right thing
> to do, applications that want to use the :scale parameter to transform
> their images shouldn't lose the hidpi scaling nor explicitly call
> image-compute-scaling-factor.
I don't think I'm qualified to make an intelligent decision on this by
myself (and you just asked the question not long ago, and proceeded to
coding without giving anyone any time to answer it :-(). I don't know
enough about this to make such a decision. maybe Robert, Alan, and
others would chime in and voice their opinions. failing that, please
tell more about the pro's and con's here, so that we could see what
kind of trade-offs are we talking about.
Thanks.
next prev parent reply other threads:[~2019-10-26 9:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 2:17 bug#37932: [PATCH] Support hidpi fringes and images with Cairo Carlos Pita
2019-10-26 2:30 ` Carlos Pita
2019-10-26 6:01 ` Carlos Pita
2019-10-26 6:43 ` Carlos Pita
2019-10-26 8:05 ` Carlos Pita
2019-10-26 9:14 ` Eli Zaretskii [this message]
2019-10-26 9:18 ` Carlos Pita
2019-10-27 8:22 ` Robert Pluim
2019-10-27 17:08 ` Carlos Pita
2019-10-27 17:10 ` Carlos Pita
2024-01-10 22:15 ` Stefan Kangas
2024-01-11 17:35 ` Carlos Pita
2024-01-11 18:21 ` Stefan Kangas
2024-01-11 18:38 ` Carlos Pita
2024-01-11 19:31 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r22zvpg4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37932@debbugs.gnu.org \
--cc=carlosjosepita@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.