all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-27 60c84ad: ; * etc/TODO: Fix last change.
Date: Mon, 02 Mar 2020 17:25:26 +0200	[thread overview]
Message-ID: <83r1yaye1l.fsf@gnu.org> (raw)
In-Reply-To: <m2lfoizthy.fsf@gmail.com> (message from Robert Pluim on Mon, 02 Mar 2020 16:06:17 +0100)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Mon, 02 Mar 2020 16:06:17 +0100
> 
>     Eli> On second thought: why do you need regexp-opt in this case?  None of
>     Eli> the other composition rules we have (search lisp/language/*.el for
>     Eli> composition-function-table) use that, so why is Emoji different?
> 
> The ones in lisp/language/*.el were presumably written by hand, unlike
> the Emoji ones.
> 
> Hereʼs an example of the patterns we want to match for U+1F3C3 (there
> are longer ones):
> 
>  "\N{U+1F3C3}\N{U+200D}\N{U+2640}\N{U+FE0F}"
>  "\N{U+1F3C3}\N{U+200D}\N{U+2642}\N{U+FE0F}"
>  "\N{U+1F3C3}\N{U+1F3FB}\N{U+200D}\N{U+2640}\N{U+FE0F}"
>  "\N{U+1F3C3}\N{U+1F3FB}\N{U+200D}\N{U+2642}\N{U+FE0F}"
>  "\N{U+1F3C3}\N{U+1F3FC}\N{U+200D}\N{U+2640}\N{U+FE0F}"
>  "\N{U+1F3C3}\N{U+1F3FC}\N{U+200D}\N{U+2642}\N{U+FE0F}"
>  "\N{U+1F3C3}\N{U+1F3FD}\N{U+200D}\N{U+2640}\N{U+FE0F}"
>  "\N{U+1F3C3}\N{U+1F3FD}\N{U+200D}\N{U+2642}\N{U+FE0F}"
>  "\N{U+1F3C3}\N{U+1F3FE}\N{U+200D}\N{U+2640}\N{U+FE0F}"
>  "\N{U+1F3C3}\N{U+1F3FE}\N{U+200D}\N{U+2642}\N{U+FE0F}"
>  "\N{U+1F3C3}\N{U+1F3FF}\N{U+200D}\N{U+2640}\N{U+FE0F}"
>  "\N{U+1F3C3}\N{U+1F3FF}\N{U+200D}\N{U+2642}\N{U+FE0F}"
> 
> Now we could add 12 rules here, one for each pattern, or 1 rule with
> all the patterns as alternatives, or we could run regexp-opt and add
> one optimized pattern.

If this is easier done by hand, maybe we should just do that.  We
could instead have an automated way of _checking_ the patterns against
emoji-*.txt files and flagging the new ones to add.  After all,
Unicode files don't change too frequently, and we already use similar
practices with other Unicode data files we import, see
admin/notes/unicode.



  reply	other threads:[~2020-03-02 15:25 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200229173124.11831.98476@vcs0.savannah.gnu.org>
     [not found] ` <20200229173125.E2D3A21167@vcs0.savannah.gnu.org>
2020-03-02 10:40   ` emacs-27 60c84ad: ; * etc/TODO: Fix last change Robert Pluim
2020-03-02 11:36     ` Eli Zaretskii
2020-03-02 14:08       ` Robert Pluim
2020-03-02 14:24         ` Eli Zaretskii
2020-03-02 14:36           ` Eli Zaretskii
2020-03-02 15:06             ` Robert Pluim
2020-03-02 15:25               ` Eli Zaretskii [this message]
2020-03-02 15:42                 ` Robert Pluim
2020-03-02 15:58                   ` Eli Zaretskii
2020-03-02 16:40                     ` Robert Pluim
2020-03-02 15:34               ` Eli Zaretskii
2020-03-02 16:58         ` Stefan Monnier
2020-03-02 20:12           ` Robert Pluim
2020-03-02 20:21             ` Eli Zaretskii
2020-03-02 20:55               ` Robert Pluim
2020-03-03 12:51                 ` Robert Pluim
2020-03-03 16:06                   ` Eli Zaretskii
2020-03-04  7:23                     ` Robert Pluim
2020-03-04  9:25                       ` Robert Pluim
2020-03-04 16:04                         ` Eli Zaretskii
2020-03-04 16:54                           ` Robert Pluim
2020-03-04 17:19                             ` Eli Zaretskii
2020-03-05  7:29                               ` Robert Pluim
2020-03-05  7:56                                 ` Eli Zaretskii
2020-03-05  8:13                                   ` Robert Pluim
2020-03-05  9:38                                     ` Eli Zaretskii
2020-03-05  9:48                                       ` Robert Pluim
2020-03-05  9:53                                         ` Eli Zaretskii
2020-03-05 14:46                                           ` Robert Pluim
2020-03-05 14:59                                             ` Eli Zaretskii
2020-03-05 15:11                                               ` Robert Pluim
2020-03-05 15:24                                                 ` Eli Zaretskii
2020-03-05 16:08                                                   ` Robert Pluim
2020-03-05 19:04                                                     ` Eli Zaretskii
2020-03-06 16:32                                                       ` Robert Pluim
2020-03-06 17:05                                                         ` Eli Zaretskii
2020-03-06 17:35                                                           ` Robert Pluim
2020-03-09 23:12                                                         ` chad
2020-03-10  7:33                                                           ` Robert Pluim
2020-03-22  5:18                                                         ` YAMAMOTO Mitsuharu
2020-03-04 15:51                       ` Eli Zaretskii
2020-03-04 16:58                         ` Robert Pluim
2020-03-04 17:24                           ` Eli Zaretskii
2020-03-03 17:22                 ` Eli Zaretskii
2020-03-04  7:26                   ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r1yaye1l.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.