From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Okay to commit purely cosmetic (indendation) fixes? Date: Mon, 10 Aug 2020 18:51:40 +0300 Message-ID: <83r1se4hyr.fsf@gnu.org> References: <94dd40a5-0195-b88b-3cc1-298d32f99ad8.ref@aol.com> <94dd40a5-0195-b88b-3cc1-298d32f99ad8@aol.com> <87y2mm7owp.fsf@gnus.org> <83wo264mwo.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30801"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Clive Tovero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 10 17:52:26 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5A65-0007t0-9y for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Aug 2020 17:52:25 +0200 Original-Received: from localhost ([::1]:36248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5A64-00035q-9b for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Aug 2020 11:52:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5A5a-0002gD-NW for emacs-devel@gnu.org; Mon, 10 Aug 2020 11:51:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52785) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5A5a-0001ne-Ew; Mon, 10 Aug 2020 11:51:54 -0400 Original-Received: from [176.228.60.248] (port=4944 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k5A5Z-0005oa-Vj; Mon, 10 Aug 2020 11:51:54 -0400 In-Reply-To: (message from Clive Tovero on Mon, 10 Aug 2020 11:39:10 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253593 Archived-At: > Cc: emacs-devel@gnu.org > From: Clive Tovero > Date: Mon, 10 Aug 2020 11:39:10 -0400 > > > Yes. They make whole lines look like due to someone who only changed > > the whitespace. > > Thank you, I had heard the recommendation to not make whitespace-only > commits, I didn't understand why. I guess I would have to know what > tools you are using and what task you are doing to completely > understand--many diff tools are capable of ignoring whitespace changes > and highlighting whitespace. If you are looking at raw diff or > something, I guess that would be a problem. I had "git blame" in mind, and its Emacs equivalent "C-x v L". > My use of "coding standard" was a poor choice of words, I'm sorry for > that. I meant documentation of your software development process, > including issues like this, a "Commiter's Guide" e.g. Then you could > tell them please RTFM, and not lead to discussions like this. In that case, please start with CONTRIBUTE in the top-level directory of the Emacs source tree.