all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: trittweiler@gmail.com, 45135@debbugs.gnu.org
Subject: bug#45135: 28.0.50; [PATCH] Add option to print file names in *xref* buffer relative to project root
Date: Sat, 26 Dec 2020 09:54:58 +0200	[thread overview]
Message-ID: <83r1ndm27h.fsf@gnu.org> (raw)
In-Reply-To: <ddd389e8-d744-6847-eb29-cd2aa0d20b01@yandex.ru> (message from Dmitry Gutov on Sat, 26 Dec 2020 04:21:47 +0200)

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Sat, 26 Dec 2020 04:21:47 +0200
> 
>  (defcustom xref-file-name-display 'abs
>    "Style of file name display in *xref* buffers.
> +
>  If the value is the symbol `abs', the default, show the file names
>  in their full absolute form.
> +
>  If `nondirectory', show only the nondirectory (a.k.a. \"base name\")

The first "If" clause says "If the value is the symbol FOO", which is
clear, but the other clauses say just "If FOO", which is much less
clear.  I suggest to say something intermediate like

  If the value is FOO, ...

> +If `relative', show only the path fragment relative to the

The GNU project's coding conventions frown on using "path" for
anything but PATH-style directory lists.  Suggest to say

  If it is `relative', show only the file-name fragment relative
  to the project root directory.

Thanks.





  reply	other threads:[~2020-12-26  7:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09 15:08 bug#45135: 28.0.50; [PATCH] Add option to print file names in *xref* buffer relative to project root Tobias Rittweiler
2020-12-23  2:16 ` Dmitry Gutov
2020-12-26  2:21   ` Dmitry Gutov
2020-12-26  7:54     ` Eli Zaretskii [this message]
2020-12-27  6:55     ` Tobias Rittweiler
2020-12-30 12:05       ` Dmitry Gutov
2020-12-27  7:10   ` Tobias Rittweiler
2020-12-30  2:06     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r1ndm27h.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=45135@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=trittweiler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.