From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 28bf387: Tweak Fdirectory_append for efficiency Date: Sat, 24 Jul 2021 20:13:15 +0300 Message-ID: <83r1fny6s4.fsf@gnu.org> References: <8335s3zng8.fsf@gnu.org> <87sg031xrc.fsf@gnus.org> <831r7nzn27.fsf@gnu.org> <87k0lf1wt4.fsf@gnus.org> <83sg03y7g7.fsf@gnu.org> <87bl6r1w33.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21796"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 24 19:14:17 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7LE9-0005Sd-8o for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 19:14:17 +0200 Original-Received: from localhost ([::1]:59196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7LE8-0004WY-AB for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 13:14:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7LDN-0003qG-U9 for emacs-devel@gnu.org; Sat, 24 Jul 2021 13:13:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45936) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7LDN-00046e-N9; Sat, 24 Jul 2021 13:13:29 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3237 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7LDN-0002Pv-B0; Sat, 24 Jul 2021 13:13:29 -0400 In-Reply-To: <87bl6r1w33.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 24 Jul 2021 19:05:20 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271562 Archived-At: > From: Lars Ingebrigtsen > Cc: emacs-devel@gnu.org > Date: Sat, 24 Jul 2021 19:05:20 +0200 > > Eli Zaretskii writes: > > > The only cases that make sense to me are: > > > > . all the strings are multibyte > > . some of the strings are multibyte, and some unibyte and pure-ASCII > > . all the strings are unibyte > > > > The last case can happen when we call this function very early during > > the startup process, before we set up the file-encoding stuff, and > > thus all the file names are unibyte strings. > > I don't understand your point here, I'm afraid. > > Whenever there's > > (multibyte-string-p "/tmp") > => nil > > (multibyte-string-p "bár") > => t > > Why shouldn't I be able to run > > (directory-append "/tmp" "bár") > => "/tmp/bár" > > without caring about multibytedness? This is just a string manipulation > function (geared towards file names). You should indeed be able to do that, that's my case #2. The case that doesn't have to work and doesn't make sense is this (multibyte-string-p (encode-coding-string "bár" 'latin-1)) => nil (multibyte-string-p "/tmp/bár") => t (directory-append "/tmp/bár" (encode-coding-string "bár" 'latin-1)) => "/tmp/b\303\241r/b\341r"