From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patch: Convenience function for changing font family Date: Sun, 08 Aug 2021 09:32:39 +0300 Message-ID: <83r1f4h2ew.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39039"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Anand Tamariya Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 08 08:33:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mCcMz-000A0H-SX for ged-emacs-devel@m.gmane-mx.org; Sun, 08 Aug 2021 08:33:13 +0200 Original-Received: from localhost ([::1]:59000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCcMy-0005Op-K2 for ged-emacs-devel@m.gmane-mx.org; Sun, 08 Aug 2021 02:33:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCcMP-0004jz-4A for emacs-devel@gnu.org; Sun, 08 Aug 2021 02:32:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55016) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCcMO-0006kW-Sb; Sun, 08 Aug 2021 02:32:36 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4142 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCcMO-0004iS-Fy; Sun, 08 Aug 2021 02:32:36 -0400 In-Reply-To: (message from Anand Tamariya on Fri, 6 Aug 2021 14:33:48 +0530) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272193 Archived-At: > From: Anand Tamariya > Date: Fri, 6 Aug 2021 14:33:48 +0530 > > Here's a patch for changing the font family on the fly. It's similar to > changing font weight using the keyboard. Thanks, but how is this supposed to work? After applying the patch and loading facemenu, "M-x facemenu-set-family RET" does nothing, not even prompts for the font family; and clicking Edit->Text Properties->Face->family from the menu bar just shows "menu-bar edit Text Properties fc f" in the echo area. I think one problem is that the facemenu machinery, as you use it, expects "family" to be a face, and there's no such face. Did you test this with Emacs 28 from the master branch? Or what am I missing? P.S. Please also provide a doc string for the new function(s), and add a :version tag to any defcustom you add or change.