From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Patch proposal: display symbol source code in help buffers
Date: Tue, 21 Sep 2021 11:38:46 +0300
Message-ID: <83r1diz5k9.fsf@gnu.org>
References: <AM9PR09MB497721FD0F28CCD1FBAFBA0B96DF9@AM9PR09MB4977.eurprd09.prod.outlook.com>
 <875yuvlrz3.fsf@gnus.org>
 <CADwFkmnmWFRD_qq9ETesizZep32sHWwG7AhrCUxPwDe=9vp=zA@mail.gmail.com>
 <87r1djixiw.fsf@gnus.org> <878rzrzpfz.fsf@localhost>
 <CADwFkm=ApvXC7Mq++RE7DQE33yqz-cakO5f-xyaXv62397u7Sg@mail.gmail.com>
 <87zgs7y5wc.fsf@localhost> <87sfxyftrw.fsf@gnus.org>
 <87mto6ifd2.fsf@localhost>
 <CADwFkmk_hfYJtv72jLrO-Mubg2XuFC3YXq+4iG+FYCkwh8EVCw@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="19206"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: larsi@gnus.org, yantar92@gmail.com, arthur.miller@live.com,
 emacs-devel@gnu.org
To: Stefan Kangas <stefankangas@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 21 10:39:39 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mSbJS-0004k3-IA
	for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Sep 2021 10:39:38 +0200
Original-Received: from localhost ([::1]:36786 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mSbJQ-0000Th-Vy
	for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Sep 2021 04:39:37 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42298)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1mSbIj-0007c3-2K
 for emacs-devel@gnu.org; Tue, 21 Sep 2021 04:38:53 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34154)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1mSbIi-0007uV-K4; Tue, 21 Sep 2021 04:38:52 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4251
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1mSbIi-0006Bs-7m; Tue, 21 Sep 2021 04:38:52 -0400
In-Reply-To: <CADwFkmk_hfYJtv72jLrO-Mubg2XuFC3YXq+4iG+FYCkwh8EVCw@mail.gmail.com>
 (message from Stefan Kangas on Tue, 21 Sep 2021 00:41:22 -0700)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:275209
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/275209>

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Tue, 21 Sep 2021 00:41:22 -0700
> Cc: Arthur Miller <arthur.miller@live.com>, emacs-devel@gnu.org
> 
> Ihor Radchenko <yantar92@gmail.com> writes:
> 
> > I like this idea. Maybe we can simply change the default value of
> > find-function-after-hook like in the attached patch?
> 
> We generally prefer not to add hooks like this if we can avoid it.  We
> can usually just change the code instead.
> 
> For example, in this case maybe we could just call `push-mark' at the
> end of `help-function-def--button-function'.

Indeed, especially since the proposed change to find-func.el would
affect all users of that package.