From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50660: 28.0.50; Text artifacting when the cursor moves over text under mouse face that originally displayed a box Date: Sun, 17 Oct 2021 15:15:24 +0300 Message-ID: <83r1cjg84j.fsf@gnu.org> References: <87czp6ysw7.fsf.ref@yahoo.com> <87h7djkayk.fsf@yahoo.com> <83bl3rli53.fsf@gnu.org> <871r4njcum.fsf@yahoo.com> <83v91yiesj.fsf@gnu.org> <8735p1izzi.fsf@yahoo.com> <83k0idijq9.fsf@gnu.org> <87lf2th4ur.fsf@yahoo.com> <83fst1iivf.fsf@gnu.org> <87y26tfp6p.fsf@yahoo.com> <83ee8lihd9.fsf@gnu.org> <87lf2tfnn5.fsf@yahoo.com> <838rytig5g.fsf@gnu.org> <874k9hfltz.fsf@yahoo.com> <83wnmdgtzg.fsf@gnu.org> <87lf2tdv7c.fsf@yahoo.com> <83o87pgnqj.fsf@gnu.org> <87fst1du3o.fsf@yahoo.com> <83mtn9gmtw.fsf@gnu.org> <877dedds6t.fsf@yahoo.com> <83k0idgjzv.fsf@gnu.org> <8735p0ebip.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22832"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50660-done@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 17 14:16:59 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mc562-0005iR-OW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Oct 2021 14:16:58 +0200 Original-Received: from localhost ([::1]:55968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mc561-0004U9-OM for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Oct 2021 08:16:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mc558-00045h-IP for bug-gnu-emacs@gnu.org; Sun, 17 Oct 2021 08:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mc558-0003Hn-8x for bug-gnu-emacs@gnu.org; Sun, 17 Oct 2021 08:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mc557-0003Wf-Ta for bug-gnu-emacs@gnu.org; Sun, 17 Oct 2021 08:16:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Oct 2021 12:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50660 X-GNU-PR-Package: emacs Mail-Followup-To: 50660@debbugs.gnu.org, eliz@gnu.org, luangruo@yahoo.com Original-Received: via spool by 50660-done@debbugs.gnu.org id=D50660.163447295013532 (code D ref 50660); Sun, 17 Oct 2021 12:16:01 +0000 Original-Received: (at 50660-done) by debbugs.gnu.org; 17 Oct 2021 12:15:50 +0000 Original-Received: from localhost ([127.0.0.1]:43691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mc54w-0003WB-G5 for submit@debbugs.gnu.org; Sun, 17 Oct 2021 08:15:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mc54u-0003Vx-9C for 50660-done@debbugs.gnu.org; Sun, 17 Oct 2021 08:15:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52784) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mc54p-00033z-1j; Sun, 17 Oct 2021 08:15:43 -0400 Original-Received: from [87.69.77.57] (port=4060 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mc54Y-000412-Lh; Sun, 17 Oct 2021 08:15:42 -0400 In-Reply-To: <8735p0ebip.fsf@yahoo.com> (message from Po Lu on Sun, 17 Oct 2021 08:32:46 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217420 Archived-At: > From: Po Lu > Cc: 50660@debbugs.gnu.org > Date: Sun, 17 Oct 2021 08:32:46 +0800 > > > 1) After producing the mouse face, you should call > > prepare_face_for_display. > > > > 2) The code you add in set_glyph_string_background_width is almost > > identical to what we already have inside the loop in > > get_cursor_offset_for_mouse_face, and I wonder whether we could > > have a function to be called from these two places. > > > > Other than that, I think this is fine, thanks. > > Does this resolve your concerns? Thanks. Thanks, installed with some minor adaptations (the main of which was to find a shorter name for the new function).