From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: input-pending-p after make-frame-visible Date: Wed, 20 Oct 2021 20:40:30 +0300 Message-ID: <83r1cfa92p.fsf@gnu.org> References: <6c69780538e1957d1002@heytings.org> <322f50be-0de1-c818-819d-6ecb400de928@gmx.at> <03ab7a19-6616-445c-cdcf-588fb30a514a@gmx.at> <3205a073-a6ca-b9a5-3834-929025b70b7b@gmx.at> <83wnm7absp.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23547"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, alan@idiocy.org, gregory@heytings.org, mituharu@math.s.chiba-u.ac.jp, emacs-devel@gnu.org To: Aaron Jensen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 20 19:48:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdFhV-0005s6-KK for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 19:48:29 +0200 Original-Received: from localhost ([::1]:58072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdFhT-0004Uz-MA for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 13:48:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdFa8-0004Yy-R9 for emacs-devel@gnu.org; Wed, 20 Oct 2021 13:40:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49042) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdFZx-0001qc-Uk; Wed, 20 Oct 2021 13:40:47 -0400 Original-Received: from [87.69.77.57] (port=2353 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdFZc-0003c1-CX; Wed, 20 Oct 2021 13:40:41 -0400 In-Reply-To: (message from Aaron Jensen on Wed, 20 Oct 2021 13:15:21 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277459 Archived-At: > From: Aaron Jensen > Date: Wed, 20 Oct 2021 13:15:21 -0400 > Cc: martin rudalics , Alan Third , > Gregory Heytings , emacs-devel@gnu.org, > YAMAMOTO Mitsuharu > > On Wed, Oct 20, 2021 at 12:41 PM Eli Zaretskii wrote: > > > > > Any concerns with installing the attached? > > > > Yes: I don't think we understand what it will do, apart of fixing this > > particular problem for you. > > The primary thing that it does is make input-pending-p respect > while-no-input-ignore-events, which is necessary to make > while-no-input fully respect while-no-input-ignore-events because it > uses input-pending-p. Yes. But the change you propose is in readable_events, a function that has many more callers than just input-pending-p. In particular, one of its callers is kbd_buffer_get_event, which is the API through which Emacs reads all of its input. And now, under some circumstances, that API will ignore some events. That's scary, at least for me. > > I _might_ be okay with installing this on master, conditioned on some > > new variable, so that if some problem reveals itself, it would be easy > > to see if it's due to this change. > > Okay, let's see if we get any more clarity first and then I can > introduce a variable. What would you like to call it? And are you > referring to a new ifdef check? No, that must be a variable exposed to Lisp, so users could fiddle with it without rebuilding.