all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Redisplay resets vscroll when window start changes
Date: Mon, 15 Nov 2021 16:18:16 +0200	[thread overview]
Message-ID: <83r1bhsdsn.fsf@gnu.org> (raw)
In-Reply-To: <87k0h9pp7t.fsf@yahoo.com> (message from Po Lu on Mon, 15 Nov 2021 20:39:50 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Date: Mon, 15 Nov 2021 20:39:50 +0800
> 
> I was implementing pixel-based scrolling based on XInput 2 pixel scroll
> events earlier, and i noticed this line in xdisp.c:
> 
>  /* Handle case where place to start displaying has been specified,
>     unless the specified location is outside the accessible range.  */
>   if (w->force_start)
>     {
>       /* We set this later on if we have to adjust point.  */
>       int new_vpos = -1;
> 
>       w->force_start = false;
> -->   w->vscroll = 0;
>       w->window_end_valid = false;
> 
> It resets the vscroll whenever window start changes, which is annoying
> if you, for example, recenter the window during pixel scroll.

Yes.  This is the basis of how scrolling commands work in Emacs: they
set the window-start point.  When that happens, vscroll must be reset.

> Is it OK to control whether or not the vscroll is reset there based on a
> variable or a window parameter?  It would be very convenient to have
> such a feature.

That'd open a Pandora box of endless hacks and bug reports, so I'd
prefer not to allow that.  It is not how the present display code was
designed.  Forcing window-start and setting vscroll contradict each
other, because forcing window-start means we want the user to see the
stuff at that buffer position.

Are you using scroll commands to implement this?  If so, don't: they
are not the right way of having pixel-wise scrolling in Emacs.
Instead, scroll the display by controlling the non-zero vscroll,
without forcing window-start.



  parent reply	other threads:[~2021-11-15 14:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87k0h9pp7t.fsf.ref@yahoo.com>
2021-11-15 12:39 ` Redisplay resets vscroll when window start changes Po Lu
2021-11-15 12:44   ` Po Lu
2021-11-15 14:18   ` Eli Zaretskii [this message]
2021-11-16  0:02     ` Po Lu
2021-11-16 12:51       ` Eli Zaretskii
2021-11-16 12:54         ` Po Lu
2021-11-16 13:01           ` Po Lu
2021-11-16 13:34             ` Eli Zaretskii
2021-11-16 13:38               ` Po Lu
2021-11-16 13:45                 ` Eli Zaretskii
2021-11-16 17:12                   ` Michael Welsh Duggan
2021-11-16 18:31                     ` Eli Zaretskii
2021-11-17  3:24                       ` Stefan Monnier
2021-11-17 13:34                         ` Eli Zaretskii
2021-11-17  0:26                     ` Po Lu
2021-11-17  3:31                       ` Eli Zaretskii
2021-11-17  3:40                         ` Stefan Monnier
2021-11-17 13:40                           ` Eli Zaretskii
2021-11-17 20:40                             ` Stefan Monnier
2021-11-18  6:36                               ` Eli Zaretskii
2021-11-19  3:17                                 ` Stefan Monnier
2021-11-19  7:13                                   ` Eli Zaretskii
2021-11-19 18:07                                     ` Stefan Monnier
2021-11-19 18:43                                       ` Eli Zaretskii
2021-11-17  4:31                         ` Po Lu
2021-11-17  7:45                           ` Eli Zaretskii
2021-11-17  0:21                   ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r1bhsdsn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.