From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52839: 29.0.50; The '(declare (modes MODE...))' NEWS entry is confusing Date: Wed, 29 Dec 2021 16:45:17 +0200 Message-ID: <83r19vjwqq.fsf@gnu.org> References: <701c3a8d-d7d4-cdb8-6e10-0212db7bc35e@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39214"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52839-done@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 29 15:47:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2aEP-000A1B-6O for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Dec 2021 15:47:09 +0100 Original-Received: from localhost ([::1]:43986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2aEO-0007ig-0t for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Dec 2021 09:47:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2aDL-0007N4-CX for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2021 09:46:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2aDK-0005Bv-1M for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2021 09:46:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2aDJ-0004V8-Vj for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2021 09:46:01 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Dec 2021 14:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 52839 X-GNU-PR-Package: emacs Mail-Followup-To: 52839@debbugs.gnu.org, eliz@gnu.org, dgutov@yandex.ru Original-Received: via spool by 52839-done@debbugs.gnu.org id=D52839.164078913617261 (code D ref 52839); Wed, 29 Dec 2021 14:46:01 +0000 Original-Received: (at 52839-done) by debbugs.gnu.org; 29 Dec 2021 14:45:36 +0000 Original-Received: from localhost ([127.0.0.1]:48321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2aCt-0004UL-M7 for submit@debbugs.gnu.org; Wed, 29 Dec 2021 09:45:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2aCs-0004U4-CN for 52839-done@debbugs.gnu.org; Wed, 29 Dec 2021 09:45:34 -0500 Original-Received: from [2001:470:142:3::e] (port=41302 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2aCn-0004CB-3F; Wed, 29 Dec 2021 09:45:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=duGb83hGsFxPCOcPDmfeYKTcQqwEzAidaVa2Guts+g0=; b=rbTg+OzChWK5 XriPdvCC/xT6hyBJ+Gh50O68VHBlontjSajU8eQpDXt77C+0JPAUidXmprLL5Bd0cxf9b6ArhwV1f YgRi3X0Q/abIZ2aMazLxC0fE19Zq2m4o3Hmto1aUbXcs10+Nny+5CtNLhKwbfPMzGzIy73AO/uHSC G+GVhDYRA7L2o8gQ1Zx5CMKcho8hWKtPeatDOF/UofEPS3tXnF+z6KJmDxGyhsMq9Ma7AEDl0qX8M QY1ryRzkbMFVnS5LAOAYjAixUffvKRrluRckcrzeAFfTVvCcQQtmlexbaljsylD5Df0/swMdHBbPu SYTgRWqkCiSX5+D2h9EBRg==; Original-Received: from [87.69.77.57] (port=1319 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2aCa-0002Bk-2c; Wed, 29 Dec 2021 09:45:29 -0500 In-Reply-To: <701c3a8d-d7d4-cdb8-6e10-0212db7bc35e@yandex.ru> (message from Dmitry Gutov on Tue, 28 Dec 2021 03:49:33 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223332 Archived-At: > From: Dmitry Gutov > Date: Tue, 28 Dec 2021 03:49:33 +0200 > > It says these syntaxes "declare how completion should happen" or one of > them "can be used as a general predicate to say whether the command > should be present when completing with 'M-x TAB'", but neither have any > effect unless the user customizes read-extended-command-predicate. > > The previous entry (the one about (interactive "p" dired-mode)) doesn't > mention the predicate user option either. > > Should read-extended-command-predicate be set to > #'command-completion-default-include-p by default? Otherwise the NEWS > entries (at least one of them) should probably mention it. Thanks, I added the caveat to these NEWS entries. > When reading the manual (subsection "Specifying Modes For Commands"), > I'm feeling a similar problem. > command-completion-default-include-p *is* mentioned, but only somewhere > in the middle. That's a 75-line node, so "in the middle" is also "close to the beginning". In fact, it mentions it immediately after explaining the issue and saying that Emacs has a mechanism for tagging commands as being specific to modes. I don't see how this could be moved earlier without severely disrupting the text didactically. > The intro gives the impression that "specifying modes" will have an > effect by default. I don't think so, but I now tried to make it even more evident. > * Change the 'M-x' binding to call execute-extended-command-for-buffer > instead. The behavior of execute-extended-command won't change, but > that probably isn't going to save anybody: the user who set up the > binding to call that command explicitly is probably rare. > > * Have the subsection be actually about the command > execute-extended-command-for-buffer. Mention its binding (M-X) and say > that (interactive nil dired-mode) affects its behavior. Then mention > that by customizing read-extended-command-predicate the user can have > 'M-x' behaving like that as well. If they like. I've added the reference to execute-extended-command-for-buffer and its binding.