all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding systems
Date: Mon, 14 Feb 2022 05:32:19 +0200	[thread overview]
Message-ID: <83r186p1h8.fsf@gnu.org> (raw)
In-Reply-To: <87v8xii83e.fsf@yahoo.com> (message from Po Lu on Mon, 14 Feb 2022 08:51:17 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Mon, 14 Feb 2022 08:51:17 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > But even nonsensical text is better than no text at all, don't you
> > agree?
> >
> > And anyway, in what possible encodings could this text be?  Can't we
> > detect the encoding with reasonable success rate?
> 
> We could try the default value of locale-coding-system

That should be done in any case, I think.

> > I mean, dropping input on the floor, let alone doing that silently, is
> > pretty rough, no?
> 
> It could be accompanied with a message that the locale coding system is
> invalid.
> 
> Most keyboard input isn't dropped.  The only keyboard input that is is
> multibyte text from input methods, so it won't affect the user's ability
> to fix the locale coding system.

I'd rather we tried to decode it in any way possible.  We never do
anything like this anywhere else where decoding is involved.

> > Can't we catch those signals?
> 
> Not within C code, I think.

I don't understand why.  We do that in C in many places, see the calls
to internal_condition_case and its ilk.  Or am I missing something?



  reply	other threads:[~2022-02-14  3:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-13 13:00 master 6ed1994d27: Prevent crashes from illegal locale coding systems Eli Zaretskii
2022-02-13 13:16 ` Po Lu
2022-02-13 13:45   ` Eli Zaretskii
2022-02-14  0:51     ` Po Lu
2022-02-14  3:32       ` Eli Zaretskii [this message]
2022-02-14  4:46         ` Po Lu
2022-02-14 14:07           ` Eli Zaretskii
     [not found]             ` <87iltheyeu.fsf@yahoo.com>
     [not found]               ` <83wnhwol2o.fsf@gnu.org>
     [not found]                 ` <87tud0ybhj.fsf@yahoo.com>
     [not found]                   ` <837d9w450e.fsf@gnu.org>
2022-02-15 13:55                     ` Po Lu
2022-02-15 14:07                       ` Eli Zaretskii
2022-02-16  0:49                         ` Po Lu
2022-02-16  2:38                           ` Po Lu
2022-02-16  5:12                             ` Po Lu
2022-02-16 12:22                               ` Eli Zaretskii
2022-02-16 12:33                                 ` Po Lu
2022-02-16 12:38                                   ` Eli Zaretskii
2022-02-16 13:05                                     ` Po Lu
2022-02-16 13:33                                       ` Eli Zaretskii
2022-02-16 13:40                                         ` Po Lu
2022-02-16 14:05                                           ` Eli Zaretskii
2022-02-17  0:45                                             ` Po Lu
2022-02-17  6:31                                               ` Eli Zaretskii
2022-02-17  6:51                                                 ` Po Lu
2022-02-17  7:23                                                   ` Eli Zaretskii
2022-02-17  7:44                                                     ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r186p1h8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.