From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too Date: Mon, 11 Apr 2022 16:12:10 +0300 Message-ID: <83r16369xx.fsf@gnu.org> References: <164967696186.12152.11548736665906939483@vcs2.savannah.gnu.org> <20220411113602.7A114C0581E@vcs2.savannah.gnu.org> <87bkx73jfz.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9177"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 11 15:15:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndtsi-00026b-2x for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 15:15:00 +0200 Original-Received: from localhost ([::1]:51808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndtsg-0004NA-F5 for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 09:14:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndtpy-0002lv-FD for emacs-devel@gnu.org; Mon, 11 Apr 2022 09:12:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndtpy-0005Rn-5g; Mon, 11 Apr 2022 09:12:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fg0KgPAeMUP20ZWSeaPznrVdbXId+CI3/VWJmdJndro=; b=W0QQ1HMI36aF YLPlEhxBEnOP9JHz0zQzS5MxpOEVZ8KNUw1SDLZ51dXH72BlTwmtn2r435Zttb1iByyvSerZm5xQi i+K2XdiIlQ4JwAMhpSeakH+XLS12yq3JADj/wWPJz9q70mpfasU6c1EKrWE8mcXDXnRXxZink1oGU V7lUYJM6mj4vdzHJHQoV+JUJHKh6Bbl9r/DMHs/aBWGvAa9qxplGIeOd8v/Jl2oRw0j44c0C1UrA4 sc26cRN6RH4mlMLvov9tOsdnNQEAb4zdefjMclvu56XV8BZ+8T+hdIvpevoega8U1zBmkHTHpZThz zROdV4tPNo/18YAD/oL2Zw==; Original-Received: from [87.69.77.57] (port=4531 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndtpx-0000Jm-51; Mon, 11 Apr 2022 09:12:09 -0400 In-Reply-To: <87bkx73jfz.fsf@yahoo.com> (message from Po Lu on Mon, 11 Apr 2022 20:15:12 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288187 Archived-At: > From: Po Lu > Cc: Lars Ingebrigtsen > Date: Mon, 11 Apr 2022 20:15:12 +0800 > > > + cache->spec = spec; > > I think this should be marked, since I don't see what protects the spec > from garbage collection otherwise. 'spec' here is img->spec, right?