From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 28 on OSX: emacsclient.c:1415: warning: implicit declaration of function 'openat' Date: Mon, 18 Apr 2022 07:49:44 +0300 Message-ID: <83r15vvvvb.fsf@gnu.org> References: <7C193269-26F7-4E85-A1E6-7A3C0C1DECC6@acm.org> <83wnfnwmlx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6872"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattiase@acm.org, esq@lawlist.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 18 06:50:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngJLR-0001di-AX for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Apr 2022 06:50:37 +0200 Original-Received: from localhost ([::1]:36452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngJLQ-0007N1-3T for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Apr 2022 00:50:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngJKp-0006hT-Dc for emacs-devel@gnu.org; Mon, 18 Apr 2022 00:49:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngJKn-0006tk-Kr; Mon, 18 Apr 2022 00:49:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RmK8vGWuRL59bzEIPLWP9FNhs9Zq9+AF7SpnIHty+c8=; b=CamueRoElMZz N9GtmuV35ZJUxuD9r5H+xyv4PE7yEfwFMWgQ/KYppj1d3gfkAMfAnXZ01Vvtu306rxu96zlVk9RgZ NnvHa3OS9DE6ycJyTPvov1tfMurIXe88+4XssbBDSpQI9ifPrKTGvS0cjnkDIglWs+IUy7g1RB69M AhU+PeM+KsPif3inIjyy7DtEdMKEKSxtoXX/jaOfdVBe1KnM3ZrsmboI9GOhtSyFP1OqPDVvy/qQK QYwXeAAA7pY9KivLmFohwp+jlacDCLX9I2hrSp2pMT/AUQzoboOzTu2neRNh0LA5J2IhI+p5BiqfS qpqcAlfGfA/XL9yw8Jf/Vw==; Original-Received: from [87.69.77.57] (port=2069 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngJKn-0001mF-1T; Mon, 18 Apr 2022 00:49:57 -0400 In-Reply-To: (message from Paul Eggert on Sun, 17 Apr 2022 13:36:58 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288592 Archived-At: > Date: Sun, 17 Apr 2022 13:36:58 -0700 > Cc: mattiase@acm.org, esq@lawlist.com, emacs-devel@gnu.org > From: Paul Eggert > > On 4/17/22 12:12, Eli Zaretskii wrote: > > > We > > use 'open' and 'openat' in many places, and this change affects all of > > them. > > I don't see why. The patch affects none of the existing 'open' calls, > and just three of the 'openat' calls. 'openat' is implemented in src/w32.c for w32, and it calls 'sys_open', which supports UTF-8 encoded file names on MS-Windows. Your patch replaced that with a call to 'open', which was basically not called anywhere in Emacs before that, only internally in w32.c, via 'sys_open'. And 'sys_open' is an important part of the Emacs ability to support UTF-8 encoded file names on MS-Windows. I hope it is now more clear why such a change on a very stable branch cannot be tolerated, unless the problem it solves is a critical one (which it isn't). I'm sorry, but users of old macOS versions will have to be more active during the pretest to have their systems supported well by released Emacs versions. They can also install the patch locally if it solves their problems.