From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 28 on OSX: emacsclient.c:1415: warning: implicit declaration of function 'openat' Date: Tue, 19 Apr 2022 09:04:23 +0300 Message-ID: <83r15tvcbc.fsf@gnu.org> References: <87zgkhg5qd.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36313"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, mattiase@acm.org, esq@lawlist.com, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 19 09:34:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngiNC-0009Bq-Ve for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Apr 2022 09:34:07 +0200 Original-Received: from localhost ([::1]:38688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngiNB-0002tA-QV for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Apr 2022 03:34:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nggyb-0006x0-OF for emacs-devel@gnu.org; Tue, 19 Apr 2022 02:04:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60218) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nggyY-0006BR-Re; Tue, 19 Apr 2022 02:04:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=giw98qahvCYIOOpnv7Qp8JBshdsqu9KHjCZkAR5NOew=; b=YNQ0wcPbvQSvRe6uuCrf On2TATlljAl/e5f4vFr78hSkRSdGIYF+W3tzN6iuNCeiR3HKd01aTqL02TODb8q+yfCU+OQ77Vv8I b43RIw3xbp39xE9EdxHC7o1074GhdUC73OJeYZTvBDn8qGkoRKoX+JNbU99+zraPhHaD2nrz0xLCc StZGJ73EhDYeBdQkiaRySYiHJW+8K1UjwcgmSMuiY8iVeaP/2YiAoCEc6kWGHIGGKy2fiY5pLMuOv THoezM/wasd4o3Z0q7ck+vkKballItcJykCQOPLunKdJcZs7OVywHVKfSFRSr0vs76KCRmK4N3gAu FR+qT86O32KUyw==; Original-Received: from [87.69.77.57] (port=1465 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nggyY-0002a3-7e; Tue, 19 Apr 2022 02:04:34 -0400 In-Reply-To: (message from Alan Third on Tue, 19 Apr 2022 05:19:10 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288653 Archived-At: > Date: Tue, 19 Apr 2022 05:19:10 +0100 > From: Alan Third > Cc: Mattias Engdegård , > Keith David Bershatsky , Paul Eggert , > emacs-devel@gnu.org > > > NSDictionary *font_attribs = @{NSFontAttributeName: menuFont}; > > Welcome to the wonderful world of Objective C under GCC. > > The attached should fix this particular error. > > These problems will need to be fixed in the emacs-28 branch, assuming > we're going to continue supporting macOS 10.6. Since this affects only the macOS builds, if you consider these changes safe enough for the release branch, I don't object to installing this there. But please take into account that there are several other issues with that old version, and the changes proposed for them would affect platforms other than macOS, and some of them are on very low level, and so cannot be installed on the release branch at this time. Which means that a build of Emacs 28 on those old macOS platforms will probably not work without manual patching anyway. > FWIW, I've moved away from trying to hide warnings generated on older > versions of macOS to try and avoid the difficult to understand #if > constructions we've previously used throughout the code. I agree. We do the same for other old platforms.