From: Eli Zaretskii <eliz@gnu.org>
To: Visuwesh <visuweshm@gmail.com>
Cc: 55692@debbugs.gnu.org
Subject: bug#55692: 29.0.50; delete-selection-mode: Replace region only if set using the mouse
Date: Sun, 29 May 2022 20:10:16 +0300 [thread overview]
Message-ID: <83r14cjmdj.fsf@gnu.org> (raw)
In-Reply-To: <87mtf075ky.fsf@gmail.com> (message from Visuwesh on Sun, 29 May 2022 20:23:49 +0530)
> From: Visuwesh <visuweshm@gmail.com>
> Cc: 55692@debbugs.gnu.org
> Date: Sun, 29 May 2022 20:23:49 +0530
>
> >> Sure. I will factor out the condition into a separate function. Is
> >> that more elegant?
> >
> > No, that's overkill. I meant that if you need an 'if' to return t or
> > something else, you could instead make it return nil or something
> > else, as in
> >
> > (if SOMETHING foo)
> >
> > and reverse the condition.
> >
> > But if you still don't understand, just forget this comment.
>
> I don't think I fully understood what you meant but I took a shot at it
> anyway. Please review updated patch.
Well, that uses double negation, which IME is a sign that it can be
clarified. Is the following condition correct?
(when (and delete-selection-mode
(use-region-p)
(not buffer-read-only)
(or (null delete-selection-temporary-region)
(and (eq delete-selection-temporary-region 'selection)
(consp transient-mark-mode)
(eq (car transient-mark-mode) 'only))
(and delete-selection-temporary-region
(or (eq transient-mark-mode 'lambda)
(and (consp transient-mark-mode)
(eq (car transient-mark-mode) 'only))))))
If not, why not?
> -first. To toggle Delete Selection mode on or off, type @kbd{M-x
> -delete-selection-mode}.
> +first. If you want to replace only temporary regions, set by
> +mouse-dragging or shift-selection (@pxref{Setting Mark}) or @kbd{C-u
> +C-x C-x}, then change the variable
> +@code{delete-selection-temporary-region} to @code{t}. But if you do
> +not want to consider the region made active by @kbd{C-u C-x C-x}
> +(@pxref{Disabled Transient Mark}), then set the variable to
> +@code{selection}. To toggle Delete Selection mode on or off, type
> +@kbd{M-x delete-selection-mode}.
This text is now too complex and thus confusing. (You can only keep
using that style for boolean options.) I would rephrase:
Normally, inserting text deletes any active region, replacing it
with the text you insert. However, you can tune this behavior by
customizing the @code{delete-selection-temporary-region} option.
Its default value is @code{nil}, but you can set it to @code{t}, in
which case only temporarily-active regions will be replaced: those
which are set by dragging the mouse (@pxref{Setting Mark}) or by
shift-selection (@pxref{Shift Selection}), as well as by @kbd{C-u
C-x C-x} when Transient Mark mode is disabled. You can further tune
the behavior by setting @code{delete-selection-temporary-region} to
@code{selection}: then temporary regions activated by @kbd{C-u C-x
C-x} won't be replaced, only the ones activated by dragging the
mouse or shift-selection.
OK?
next prev parent reply other threads:[~2022-05-29 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 17:33 bug#55692: 29.0.50; delete-selection-mode: Replace region only if set using the mouse Visuwesh
2022-05-28 19:10 ` Eli Zaretskii
2022-05-29 6:17 ` Visuwesh
2022-05-29 6:52 ` Eli Zaretskii
2022-05-29 8:10 ` Visuwesh
2022-05-29 9:04 ` Eli Zaretskii
2022-05-29 14:53 ` Visuwesh
2022-05-29 17:10 ` Eli Zaretskii [this message]
2022-05-31 10:44 ` Visuwesh
2022-05-31 14:33 ` Drew Adams
2022-06-01 16:04 ` Eli Zaretskii
2022-06-01 17:03 ` Visuwesh
2022-09-06 10:59 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r14cjmdj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55692@debbugs.gnu.org \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.