From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56425: 28.1; post-command-hook is triggered on y-or-n-p Date: Mon, 11 Jul 2022 14:39:31 +0300 Message-ID: <83r12rzxn0.fsf@gnu.org> References: <83tu7u5ai6.fsf@gnu.org> <87v8s3yl5p.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23085"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bhavin7392@gmail.com, 56425@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 11 13:42:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAro5-0005r8-MP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jul 2022 13:42:29 +0200 Original-Received: from localhost ([::1]:48036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAro4-0001NH-Pk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jul 2022 07:42:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oArlj-0000Hl-Td for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 07:40:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oArli-0005i5-R4 for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 07:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oArli-0000RU-Nc for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 07:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2022 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56425 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 56425-submit@debbugs.gnu.org id=B56425.16575395941669 (code B ref 56425); Mon, 11 Jul 2022 11:40:02 +0000 Original-Received: (at 56425) by debbugs.gnu.org; 11 Jul 2022 11:39:54 +0000 Original-Received: from localhost ([127.0.0.1]:38644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oArla-0000Qp-7y for submit@debbugs.gnu.org; Mon, 11 Jul 2022 07:39:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oArlY-0000Qe-Nu for 56425@debbugs.gnu.org; Mon, 11 Jul 2022 07:39:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oArlT-0005eR-Fm; Mon, 11 Jul 2022 07:39:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fvuh3kBwQm3cbTwVrn/yTtkDsi2+ldDYGGw4yx9smFM=; b=pvJvV0qJ+JbY QoAr0dYDYRJCaGcsDHC66oM1aNKRGEhF8Szu9YpQHOfFkDHdkobRnrFql67gu27/IlxS+ne6hR31K Lmj6JAlRp2JO+FswRn9wHuY/AzYsb9uPPKjAgpiJd6j/su93rpRTyZ/8bAAJrKsCPlSsCkl1LiZ2c Dhjn4yL0HUhXIQ8Dwfcs1IaW0VqERhskXAST7kMYrUChsjJOtalFXmoZorpP7AFwa8SHXjzjcbax/ Ncizl61rzXr9y1k4wafgjxJwLm2UvgrM72tqA/Mxjk4olqVAvrTNrOPTUbRNIro6yGZG1yn7kvuHr r/QWA7BeVp0wV7FfbdQdWg==; Original-Received: from [87.69.77.57] (port=4044 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oArlP-0003sp-J8; Mon, 11 Jul 2022 07:39:47 -0400 In-Reply-To: <87v8s3yl5p.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 11 Jul 2022 12:54:26 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236663 Archived-At: > From: Lars Ingebrigtsen > Cc: Bhavin Gandhi , 56425@debbugs.gnu.org > Date: Mon, 11 Jul 2022 12:54:26 +0200 > > Eli Zaretskii writes: > > > Why are you surprised? y-or-n-p invokes read-from-minibuffer, which > > invokes recursive-edit, which starts a recursive command loop. And > > the command loop calls post-command-hook on each iteration. > > When writing post-command-hook code, you have to be check whether you're > in the context you want to be (for instance, in the minubuffer or not). > I think it's always been this way, but these day we use the > read-from-minibuffer a lot more than we used to -- so y-or-n-p didn't > use to have this issue, but it does now. Yes. Code that wants to distinguish these cases from "normal" post-command-hook invocations should examine the value of minibuffer-depth, I think.