From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Splitting image-dired.el into smaller files Date: Sun, 21 Aug 2022 18:20:30 +0300 Message-ID: <83r119bp35.fsf@gnu.org> References: <83sflqcfhk.fsf@gnu.org> <83tu65br5f.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9278"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, mathias.dahl@gmail.com To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 21 17:21:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oPmlO-0002IT-Fw for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 17:21:22 +0200 Original-Received: from localhost ([::1]:47088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPmlN-0005en-Fa for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 11:21:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPmkY-0004yc-Os for emacs-devel@gnu.org; Sun, 21 Aug 2022 11:20:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPmkY-0000Re-Cq; Sun, 21 Aug 2022 11:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZOxU9fELRy1hN5NazpQDX1EKdSfUD7PvG214g4p2rBg=; b=LN5EFwqns1SX cAxpOf7B3yVR9TEtBu36xvxXASqC1m9WuDkGnq1fBa6uni9D7pke6oG/GqEaU0hq/kIduRy4xXlfe /ObERIS4IOJFfDVG5pKnIQFdL9otLqTfot0046uyXZDQGR0pZJaHAWSuK8F8yBeaZueN7zuNR/5mk YDuuaixM8AO0am38UglUIvp+sGkIswK5b83Z1vjTZFGMmorpfZk1uR0TR/nmuOGoXQCNl2GDvahMQ 6gLbjXIPFirNv+HrxF+vAtT/4v1nhqZMoU6im2UGKo8ocG7ZJrKwCe+QfxGItqftwMY3mdVvp+keq h4J3PJLC0sEqdTZ2OlVyRg==; Original-Received: from [87.69.77.57] (port=4250 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPmkX-0003Oc-RC; Sun, 21 Aug 2022 11:20:30 -0400 In-Reply-To: (message from Stefan Kangas on Sun, 21 Aug 2022 08:11:08 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293738 Archived-At: > From: Stefan Kangas > Date: Sun, 21 Aug 2022 08:11:08 -0700 > Cc: emacs-devel@gnu.org, mathias.dahl@gmail.com > > Eli Zaretskii writes: > > > Remove the "image-dired-" part? > > Do you mean naming the files like this? > > image-dired/compat.el > image-dired/dired.el > image-dired/external.el > image-dired/gallery.el > image-dired/tags.el > image-dired/util.el > image-dired/image-dired.el Yes. > How would I then require them, is it like this? > > (require 'image-dired/compat) > > If that works, it does sound a bit neater. It does work: we use it in cedet/ subdirectories. > > And maybe leave the -util.el part inside the main file? > > That's not very easy to do without introducing circular dependencies, > unfortunately. How come, when all the code now lives on the same file and we don't have any problems? Maybe your factoring between the files needs revisiting?