From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 2a7f01aa38: Fix initialization of module functions
Date: Thu, 10 Nov 2022 17:23:52 +0200
Message-ID: <83r0yarfxz.fsf@gnu.org>
References: <166807775643.29181.14745596143667535171@vcs2.savannah.gnu.org>
 <20221110105556.B16E8C0E4C9@vcs2.savannah.gnu.org>
 <jwv5yfmucpe.fsf-monnier+emacs@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="31138"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 10 16:24:26 2022
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1ot9Pm-0007qs-Ez
	for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Nov 2022 16:24:26 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1ot9PH-0007Ah-0W; Thu, 10 Nov 2022 10:23:55 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1ot9PF-0007AR-0k
 for emacs-devel@gnu.org; Thu, 10 Nov 2022 10:23:53 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ot9PE-0006kn-P1; Thu, 10 Nov 2022 10:23:52 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=2iNxT+jrRW8oMoxBj0B5ABCECO/Ze3L+v/vd0glr/ZI=; b=AoKt65TsJDXX
 oXrxNf2sZZG6o6Ujm9EDWWACaDvW2sylebccLUvo9ns+G7J3trIb6db9Jmbb3TQLUtAZpAthhyVZ6
 TMYiuWSQ112eQuhD/T8Kp1VYLoXBO4JoJYvfvXa0DrRiD9AjZee0b0jSd+7DScocEtSknylsgNKQR
 Y8p/2prF9P0Vi4X+V47oO/V+EbfD5CXgRzRnHq1MN7UFhgSUXogZICGn3uvwTNcExkYsPOOqfTB0y
 RZL8eIJY/6D/lZ/Zwszb2Bm6FYzljrQY0GfnrRqDI0+H4ajx04bwX8PhHIAIjW+JKxAX0mZZ2JQmj
 RdTZ6ZhsfVfkKO5TXr6zmg==;
Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ot9PE-0005jj-2Y; Thu, 10 Nov 2022 10:23:52 -0500
In-Reply-To: <jwv5yfmucpe.fsf-monnier+emacs@gnu.org> (message from Stefan
 Monnier on Thu, 10 Nov 2022 09:06:35 -0500)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:299493
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/299493>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 10 Nov 2022 09:06:35 -0500
> 
> >  allocate_module_function (void)
> >  {
> >    return ALLOCATE_PSEUDOVECTOR (struct Lisp_Module_Function,
> > -                                interactive_form, PVEC_MODULE_FUNCTION);
> > +                                command_modes, PVEC_MODULE_FUNCTION);
> >  }
> >  
> >  #define XSET_MODULE_FUNCTION(var, ptr) \
> 
> Usually we accompany that with a comment in the struct stating "this
> is the last GC-tracked field" or something like that.

There's already such a comment, a few lines above.