From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Date: Sat, 26 Nov 2022 22:35:57 +0200 Message-ID: <83r0xpqwr6.fsf@gnu.org> References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> <83ilj1srma.fsf@gnu.org> <83v8n1qz3k.fsf@gnu.org> <2be2d630-f4da-16f9-5afc-9f6561a9995a@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11114"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58877@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 26 21:36:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oz1uC-0002fi-Kx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Nov 2022 21:36:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oz1u8-0005zu-Dz; Sat, 26 Nov 2022 15:36:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz1u6-0005wK-Df for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 15:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oz1u6-0006q7-5X for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 15:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oz1u5-0006xf-JR for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 15:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 20:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166949494226750 (code B ref 58877); Sat, 26 Nov 2022 20:36:01 +0000 Original-Received: (at 58877) by debbugs.gnu.org; 26 Nov 2022 20:35:42 +0000 Original-Received: from localhost ([127.0.0.1]:41548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz1tm-0006xO-DS for submit@debbugs.gnu.org; Sat, 26 Nov 2022 15:35:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz1ti-0006xI-4z for 58877@debbugs.gnu.org; Sat, 26 Nov 2022 15:35:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz1tc-0006ir-0J; Sat, 26 Nov 2022 15:35:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QOF76dJOHnGCAm+9ogstrIWiYg3pjSli9HJRZ2kgw9A=; b=SFnsGxSpPwIA 2VSkvL3xu5CIQqov1ufMW7HKioV69+L8AoyaDDWlYBbXXBYn9aoDvVBTD77e3DmrDiIiCocA3IhxN 8VReVQ7I8hd6+G30d+5W74QhSm7HM50KzImvklldF1X2zCt4VdEMW06E3ScLbGpF0hikTIJSiA+SZ ZnxkFYJTXeSHDNNhI/M2bya0RPW9QqjW0/3E7iiWUI9gNkGGJTxzxQ3vbUhAjjV9lUKHVBmfzoPl3 nu+wajiewFyymaneh4PdhU3PJ4h7Xldny1HP92lCTiPQ9kWHzElofglq52JbH3ybxG4mperOWzsGO ZFDr/wm6Hxnyzr/ejVsV7A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz1tb-00059s-FU; Sat, 26 Nov 2022 15:35:31 -0500 In-Reply-To: <2be2d630-f4da-16f9-5afc-9f6561a9995a@gmail.com> (message from Jim Porter on Sat, 26 Nov 2022 12:17:59 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249142 Archived-At: > Date: Sat, 26 Nov 2022 12:17:59 -0800 > Cc: 58877@debbugs.gnu.org > From: Jim Porter > > > Client output: *ERROR*: Not using an ASCII terminal now; cannot make a new ASCII frame > > > > Process d:/gnu/git/emacs/trunk/lib-src/emacsclient exited abnormally with code 1 > > > > This is because emacsclient on Windows cannot create new terminal frames, > > only new GUI frames, unless Emacs was started as "emacs -nw". > > > > Why do these tests need TTY frames? > > The test code just calls "emacsclient -c", and they should be happy with > any kind of frame, TTY or GUI. I guess that by running in batch mode, > Emacs will try to create TTY frames, but that fails on MS Windows? I guess. And I'm not prepared to spend time trying to make emacsclient work with a batch-mode server on MS-Windows. > > Btw, with the above changes, only 3 tests fail: > > > > 3 unexpected results: > > FAILED server-tests/emacsclient/create-frame > > FAILED server-tests/server-force-stop/keeps-frames > > FAILED server-tests/server-start/stop-prompt-with-client > > > > So this is progress, thanks. > > All these tests involve creating client frames, so that makes sense. I'm > not sure how to coax Emacs into creating GUI frames on MS Windows for > these tests though. Still, I don't think these failures are a sign of > anything broken exactly; it's just the combination of MS Windows' > limitations with trying to create frames in an Emacs batch session. > > Unless you have an idea for how to fix that (I've got no clue, > unfortunately), how about just skipping these tests on MS Windows, with > a comment explaining what the limitation is? Fine with me, thanks.