From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59626: 29.0.50; [PATCH] comint-fontify-input: Fix field boundary issue Date: Sun, 27 Nov 2022 14:27:14 +0200 Message-ID: <83r0xopopp.fsf@gnu.org> References: <875yf03g42.fsf@miha-pc> <83y1rwpwh8.fsf@gnu.org> <8735a437tx.fsf@miha-pc> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3177"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59626@debbugs.gnu.org To: Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 27 13:27:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozGkc-0000aJ-Sb for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Nov 2022 13:27:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozGkV-0007wV-Hw; Sun, 27 Nov 2022 07:27:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozGkR-0007vz-5M for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 07:27:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozGkQ-0002Io-07 for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 07:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozGkP-0001rc-Se for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 07:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Nov 2022 12:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59626 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59626-submit@debbugs.gnu.org id=B59626.16695520167157 (code B ref 59626); Sun, 27 Nov 2022 12:27:01 +0000 Original-Received: (at 59626) by debbugs.gnu.org; 27 Nov 2022 12:26:56 +0000 Original-Received: from localhost ([127.0.0.1]:42229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozGkK-0001rN-5C for submit@debbugs.gnu.org; Sun, 27 Nov 2022 07:26:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozGkH-0001rH-Uy for 59626@debbugs.gnu.org; Sun, 27 Nov 2022 07:26:54 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozGkB-0002HL-Dk; Sun, 27 Nov 2022 07:26:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZeX8WdN2oUBD+vMl+0B3bSEfbENdvTOWNBtldoDvYQ4=; b=jX9VibD4sUKp 4QpLrjkKluwRKuPrgwo3wG8e9MYsCtBz3xd0dzniNHuqeDkxYw/0Mpu5xkheVMqyNuTOXVrH3aw6n a+6h9iqUvGLKDMOedIk+4U73gWEz2OG8WPSrk3ahdBTLgUpfPqV9fsIiIDVGwJ1YwBgojlU1xs+kc lwoTzGaW8CNzE325FLKgepkVy1MozKz+u8eTMvW5tJpYfZYnQEy8HDW9SwKH+A5+y1QC8gSDhicMe 4Q8F/CFWzumqPEKwepgxSOrups6oUqxahBf0kED+KvEnNz50dgHglvGRplHrUjtWjPgevxPpQ1Mfj by3JM1+6L8qMr3CUbpPKxg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozGkA-0006F8-K4; Sun, 27 Nov 2022 07:26:47 -0500 In-Reply-To: <8735a437tx.fsf@miha-pc> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249204 Archived-At: > From: > Cc: 59626@debbugs.gnu.org > Date: Sun, 27 Nov 2022 13:22:50 +0100 > > > Thanks. Do you have a recipe for demonstrating the problem which you are > > trying to fix? > > Instrument comint input fontification with this diff: > > diff --git a/lisp/comint.el b/lisp/comint.el > index f47e6089f2..c83da95ad2 100644 > --- a/lisp/comint.el > +++ b/lisp/comint.el > @@ -4083,7 +4083,10 @@ comint--fontify-input-fontify-region > nil (lambda (beg end) > (unless (get-text-property > beg 'comint--fontify-input-inhibit-fontification) > - (font-lock-fontify-region beg end verbose))) > + (font-lock-fontify-region beg end verbose) > + ;; Output contents of the visible portion of the > + ;; buffer to *Messages*. > + (message "%S" (buffer-substring-no-properties (point-min) (point-max))))) > beg end))) > (`((jit-lock-bounds ,beg1 . ,_) . (jit-lock-bounds ,_ . ,end1)) > (setq beg (min beg beg1)) > > Now open up an M-x shell and type "date RET" into the buffer to make > your shell output the current date and an new prompt. Press "C-p C-p > C-e" to move point to "date" and change it into "datee". > > Open up *Messages* and find the following strings: > > "date" > > "date > " > > "datee > Sun Nov 27 01:05:27 PM CET 2022 > ~$ " > > These strings represent the context in which shell fontification was > performed on the input. The last one includes "Sun Nov 27 01:05:27 PM > CET 2022\n~$ ", which is a mistake that this patch attempts to fix. > However, in pretty much all cases, this didn't result in any user > visible inaccuracies, since shell fontification of a command rarely > depends on the contents of the lines that follow it. Thanks, I will study this. > >> Not that my copyright paperwork renewal is currently in progress, but I > >> hope that the number of lines in this patch fall below the threshold. > > > > Since when your previous assignment became outdated? I need to know that to > > make sure the cumulative amount of changes we already received from you > > doesn't exceed the limit. > > 24. of October this year. Then it's okay to install this without an assignment (when we decide to install it).