From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59745: 26.3; Rename `string-collate-lessp' to respect the convention Date: Thu, 01 Dec 2022 18:50:21 +0200 Message-ID: <83r0xjgjaq.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11328"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59745@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 01 17:51:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0mmK-0002i9-Rp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Dec 2022 17:51:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0mmG-0000VQ-TL; Thu, 01 Dec 2022 11:51:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0mmC-0000TF-06 for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 11:51:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0mm7-0001D5-Br for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 11:51:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0mm6-0005fK-7J for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 11:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Dec 2022 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59745 X-GNU-PR-Package: emacs Original-Received: via spool by 59745-submit@debbugs.gnu.org id=B59745.166991345921766 (code B ref 59745); Thu, 01 Dec 2022 16:51:02 +0000 Original-Received: (at 59745) by debbugs.gnu.org; 1 Dec 2022 16:50:59 +0000 Original-Received: from localhost ([127.0.0.1]:40760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0mm3-0005ez-66 for submit@debbugs.gnu.org; Thu, 01 Dec 2022 11:50:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0mm1-0005eo-57; Thu, 01 Dec 2022 11:50:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0mlt-00013S-Ra; Thu, 01 Dec 2022 11:50:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rsmMQBoa7IIHv2tNMtwOdwBzTCHLqNYGWf1XnjxRcH8=; b=DBq6GaY2IOft Q7IDoAQeKGSDYIbJ+sQMr3CrcNYHii7XiQ8XhywOUcktMPDNFKyf2yRpaMdXFPpbVBrFcNi2GgDBH XdVKR+hC2O1c59MFfNfqfjHct48TB08h5Vd25304sBtIbgtPsXo9wqi20zCryLyxnMJKPR0J/2lk8 cVNWdQ/mA19EX3o1TMEcYgrf6nZrFgZeT+F9F7Jxbyo8Zth2L+mF4BpgM+hEYtwcR8Vmqcf8r9PKX bv+yYA6K2qwlntkjQtduR1QFadPmmTpMyUy0A1VQtzN9S+BVWi/wH8Z7N8RLMiI6KE4Hcgjyyda9G 9mkMqpEbPun56Go2n8WwpA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0mlt-0004HM-Aq; Thu, 01 Dec 2022 11:50:49 -0500 In-Reply-To: (message from Drew Adams on Thu, 1 Dec 2022 16:19:31 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249651 Archived-At: tags 59745 wontfix close 59745 thanks > From: Drew Adams > Date: Thu, 1 Dec 2022 16:19:31 +0000 > > (elisp) `Coding Conventions' tells us: > > If the purpose of a function is to tell you whether a certain > condition is true or false, give the function a name that ends in > 'p' (which stands for "predicate"). If the name is one word, add > just 'p'; if the name is multiple words, add '-p'. Examples are > 'framep' and 'frame-live-p'. > > `string-collate-lessp' should, according to convention, be renamed to > `string-collate-less-p', no? Every such misnaming encourages others, > as people tend to base new names on names they see for existing things. We also have bufferp, stringp etc., so -lessp is not so bad, especially since it's modeled on string-lessp. And anyway, it's too late now for renaming. Closing.